Repository navigation
fix(rules): match ssh-add -l after other options in ssh-agent-key-enumeration - #1050
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
ssh-agent-key-enumerationrequires the list flag to be the first argument ofssh-add(ssh-add\s+(-[A-Za-z]*[lL])). Putting any option first hides the listing. Sossh-add -E md5 -l, the usual way to list loaded keys with MD5 fingerprints, went unflagged.The fix
The
-l/-Lflag may come after other arguments in the same command:ssh-add\b[^;&|]*\s-[A-Za-z]*[lL]. Adding a key whose path contains-l(ssh-add ~/.ssh/deploy-lab) still does not match, because the flag must start a word. The rule version is now 2.Tests
I added a match fixture for
ssh-add -E md5 -land a no_match forssh-add ~/.ssh/deploy-lab. Before the fix:What I ran