Repository navigation
fix(rules): match crontab file loads followed by another command - #1048
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The
crontab <file>clause incrontab-modificationmatches only when the file is the last thing on the line (\s+[a-zA-Z0-9_./]+\s*$), and its character class has no~. Two common installs were missed:crontab /tmp/payload.cron && rm /tmp/payload.cron.crontab ~/jobs.cron.Both replace the user's crontab, which is the persistence the rule exists to catch.
The fix
The file operand may contain
~and may be followed by end of line or a command separator:\s+[a-zA-Z0-9_./~]+\s*($|[;&|]). A listing likecrontab -l && echo donestill does not match, because-lis not a file operand. The rule version is now 2.Tests
I added two match fixtures and one no_match fixture. Before the fix:
What I ran