feat: start defaults to the dashboard manifest#170
Merged
Conversation
A bare 'trading-bot start --serve' now runs and serves the same book the dashboard manages: with no --config, the daemon loads configs/dashboard.yaml when it exists (announcing it), else keeps the bare paper-config fallback. run/serve deliberately keep requiring an explicit path — silently picking up a manifest that declares real strategies there would surprise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no
--config,trading-bot startnow loadsconfigs/dashboard.yamlwhen it exists — the same persistent manifestdashboardreads and rewrites — so a baretrading-bot start --serveruns and serves the managed book with no path to remember (it printsusing default manifest configs/dashboard.yamlso what governs trading is always explicit). Absent that file the bare paper-config fallback is unchanged, andrun/servekeep requiring an explicit path (auto-picking up real strategies there would surprise).Requested by the maintainer after #167 (
start --servehonouring the manifestui:section) made the config the single thing left to type.🤖 Generated with Claude Code