Skip to content

chore(js): upgrade Changesets publishing #15718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeldking merged 1 commit into from
Aug 29, 2026
+220 −414
Merged

chore(js): upgrade Changesets publishing #15718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions .github/workflows/typescript-packages-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,18 @@ jobs:
- name: create and publish versions
# Using PAT instead of GITHUB_TOKEN so that PRs created by this action
# can trigger subsequent workflows (like publish) when merged
# Pinned to v1.5.2 because released versions after that still break monorepo
# cwd handling; the upstream fix merged after v1.7.0 but is not released yet.
uses: changesets/action@d183df40791e90508058cd180e6435cdd9ba16a4 # v1.5.2
uses: changesets/action@8488615a623b1b9c987934bb89eae8af6a946ac1 # v2.1.1

@claude claude Bot Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned SHA does not exist in changesets/action, so this step will fail to resolve.

8488615a623b1b9c987934bb89eae8af6a946ac1 is not a commit in changesets/action (or anywhere on GitHub):

$ gh search commits --hash 8488615a623b1b9c987934bb89eae8af6a946ac1 --json sha,repository
[]

The actual v2.1.1 release commit is d7669c894a691cf0908002c33cdd57df54a1ef3b — the merge commit of changesets/action#722 ("Version Packages", body: ## @changesets/action@2.1.1), merged 2026-08-19. That SHA does resolve, confirming the search index is current and the empty result above is a genuine miss rather than an indexing gap.

uses: with an unresolvable SHA fails immediately with Unable to resolve action changesets/action@8488615…. This workflow is on: push: branches: [main], so nothing in PR CI exercises it — the first symptom would be a broken JS package release after merge.

phoenix/.github/workflows/typescript-packages-publish.yml

Lines 50 to 52 in 72d5a8e

# can trigger subsequent workflows (like publish) when merged
uses: changesets/action@8488615a623b1b9c987934bb89eae8af6a946ac1 # v2.1.1
with:

Suggested change
uses: changesets/action@8488615a623b1b9c987934bb89eae8af6a946ac1 # v2.1.1
uses: changesets/action@d7669c894a691cf0908002c33cdd57df54a1ef3b # v2.1.1

For what it's worth, the rest of the migration checks out: the renamed inputs (version-script, publish-script, commit-message, pr-title, create-github-releases), the move of the token from GITHUB_TOKEN env to the github-token input, and the relative cwd: js are all correct for v2 — and the @changesets/cli v3 bump is in fact required by v2's validateChangesetsCliVersion check.

@mikeldking mikeldking Aug 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive — 8488615a623b1b9c987934bb89eae8af6a946ac1 is exactly what changesets/action@v2.1.1 resolves to.

v2.1.1 is an annotated tag, so the ref points at a tag object, not directly at the commit:

$ gh api repos/changesets/action/git/ref/tags/v2.1.1
{"ref":"refs/tags/v2.1.1","type":"tag","sha":"fdf536a68c4154480c89b42547f8102cf0d8bc47"}

$ gh api repos/changesets/action/git/tags/fdf536a68c4154480c89b42547f8102cf0d8bc47
{"tag":"v2.1.1","object":{"type":"commit","sha":"8488615a623b1b9c987934bb89eae8af6a946ac1"}}

$ gh api repos/changesets/action/commits/8488615a623b1b9c987934bb89eae8af6a946ac1
{"sha":"8488615a...","msg":"v2.1.1","date":"2026-08-19T06:36:34Z"}

The empty gh search commits --hash result is a search-index miss, not proof of absence — the commits API resolves the SHA fine.

The suggested d7669c894a691cf0908002c33cdd57df54a1ef3b is Version Packages (#722) from 2026-08-19T05:29:59Z, roughly an hour before the commit the tag actually points at. Taking the suggestion would pin a commit that v2.1.1 does not reference, so the # v2.1.1 comment would become inaccurate. Leaving the pin as-is.

with:
version: pnpm ci:version
commit: "chore(js): update versions"
title: "chore(js): update versions"
publish: pnpm ci:publish
createGithubReleases: true
# v1.5.2 resolves cwd relative to the action runtime, not github.workspace.
cwd: "${{ github.workspace }}/js"
github-token: ${{ secrets.MY_CHANGESET_TOKEN }}
version-script: pnpm ci:version
commit-message: "chore(js): update versions"
pr-title: "chore(js): update versions"
publish-script: pnpm ci:publish
create-github-releases: true
cwd: js
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.MY_CHANGESET_TOKEN }}
# - name: Release docs
# Run pnpm run docs in js/packages/phoenix-client
# Deploy the static files in js/packages/phoenix-client/docs to github pages
2 changes: 1 addition & 1 deletion js/.changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://unpkg.com/@changesets/config@3.0.4/schema.json",
"$schema": "https://unpkg.com/@changesets/config@4.0.0/schema.json",
"changelog": "@changesets/cli/changelog",
"commit": false,
"fixed": [],
Expand Down
2 changes: 1 addition & 1 deletion js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"typecheck": "pnpm run -r typecheck"
},
"devDependencies": {
"@changesets/cli": "^2.31.1",
"@changesets/cli": "^3.0.1",
"oxfmt": "^0.58.0",
"oxlint": "~1.79.0",
"oxlint-tsgolint": "~7.0.2001",
Expand Down
Loading
Loading