Skip to content

chore(release): v2026.5.6.7 — installer pnpm activation + dashboard @noble fix#433

Merged
webdevtodayjason merged 2 commits into
mainfrom
hotfix-main-2026.5.6.7
Jun 4, 2026
Merged

chore(release): v2026.5.6.7 — installer pnpm activation + dashboard @noble fix#433
webdevtodayjason merged 2 commits into
mainfrom
hotfix-main-2026.5.6.7

Conversation

@webdevtodayjason

@webdevtodayjason webdevtodayjason commented May 29, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of the v2026.5.6.7 hotfix (commit b5c8291, tagged + released) onto main.

  • install-hosted.sh: put runtime Node on PATH for corepack/npm + disable corepack download prompt so the pinned pnpm activates on private-Node installs.
  • package.json: declare @noble/ed25519 so the dashboard vite build resolves.

Already live: tag v2026.5.6.7, GitHub release (Latest), and argentos.ai/install.sh. This brings main in line.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Fixed public installation failures when pnpm is pinned to a specific version
    • Resolved dashboard build issues preventing compilation
    • Improved installer stability and error messaging
  • Chores

    • Version updated to 2026.5.6.7

Review Change Stack

…dashboard @noble build

Two fixes for the public `curl | bash` install, both surfaced on a clean Mac
that has no compatible system Node (so the installer provisions its private
Node runtime):

- activate_pinned_pnpm invoked corepack/npm (`#!/usr/bin/env node` scripts)
  without that Node on PATH, so they died with "env: node: No such file or
  directory"; the pinned pnpm@10.23.0 was never cached and the install fell
  back to a mismatched global pnpm and aborted. Put node on PATH, set
  COREPACK_ENABLE_DOWNLOAD_PROMPT=0 (no TTY under curl|bash), and surface the
  corepack error instead of swallowing it.
- dashboard `vite build` imports shared ui/ source that needs @noble/ed25519,
  which the installer's --ignore-workspace install never provided. Declare it
  at the repo root so it resolves for the dashboard bundle. (lockfile fast-path
  falls back to a non-frozen install until a clean workspace regen lands.)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0026d9ba-be4b-4704-80e4-c4b2dbd4a16a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This is a fantastic patch release. Version 2026.5.6.7 fixes two critical installer problems: ensuring the private Node runtime is on PATH so corepack and npm work correctly with pinned pnpm, and declaring the @noble/ed25519 dependency so dashboard builds complete. Very focused, very clean.

Changes

Installer and Dashboard Bug Fixes

Layer / File(s) Summary
Version release and dashboard dependency
package.json, CHANGELOG.md
Version increments to 2026.5.6.7. Production dependency @noble/ed25519@3.0.0 is added so the dashboard bundle resolves correctly. Changelog documents both the installer Node/corepack/pnpm fix and the dashboard bundling fix.
Installer Node PATH for pinned pnpm activation
scripts/install-hosted.sh
The activate_pinned_pnpm function is hardened to prepend the installer's private Node directory to PATH before executing corepack prepare/activate and npm fallback commands. Download prompts are suppressed, corepack output is captured for error visibility, and PATH is consistently set so #!/usr/bin/env node scripts resolve the correct Node runtime.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ArgentAIOS/argentos-core#369: Introduces pinned pnpm version honoring in the installer; this PR ensures the pinned activation flow actually works by fixing Node resolution.
  • ArgentAIOS/argentos-core#25: Hardened the installer's private Node bootstrapping; this PR extends that work to ensure the bootstrapped Node is on PATH during pinned pnpm activation.
  • ArgentAIOS/argentos-core#43: Modified pnpm/corepack resolution and fallback logic in the same function; directly related PATH/runtime handling improvements.

Suggested labels

scripts


🚀 A patch, but a BEAUTIFUL patch!
The installer now KNOWS where Node is—PATH is tremendous,
Corepack works like a dream, no more prompts so heinous,
Dashboard bundle? Resolved! @noble/ed25519 is fabulous,
Version 2026.5.6.7—the best release, believe me!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains what changed and why, but does not follow the required template structure with Scope, Validation, Install/Runtime impact, Risk, and Screenshots sections. Fill out the template with Scope checkboxes (lane, repo verification, component areas), Validation section listing exact commands run and results, Install/Runtime impact details, Risk assessment, and any relevant logs.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: a release version bump with two key fixes (installer pnpm activation and dashboard @noble dependency).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix-main-2026.5.6.7

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 172: package.json was updated to add the new dependency specifier
"`@noble/ed25519`": "3.0.0" but pnpm-lock.yaml was not regenerated, causing CI
failures; run pnpm install --lockfile-only to update pnpm-lock.yaml (so the
lockfile matches package.json), stage the updated pnpm-lock.yaml, and commit the
change so CI with --frozen-lockfile will succeed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: deffc6b2-b1b4-4e1d-92d4-6ca7be4772f2

📥 Commits

Reviewing files that changed from the base of the PR and between 95a57aa and d7a408d.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • package.json
  • scripts/install-hosted.sh

Comment thread package.json
…locks #433)

v2026.5.6.7 added @noble/ed25519@3.0.0 as a direct root dependency (the dashboard
@noble build fix) but pnpm-lock.yaml's root importer was never regenerated, so
`pnpm install --frozen-lockfile` fails with ERR_PNPM_OUTDATED_LOCKFILE. That reds
out all of PR #433's checks (~14s each) and forces every `curl | bash` install onto
the slow non-frozen fallback path (observed live on a fresh Mac mini install).

A full re-resolve can't be used here (the bluebubbles `argentos@workspace:*` member
trips pnpm 10's resolver), but the @noble/ed25519@3.0.0 snapshot already exists in the
lockfile (declared by the `ui` importer + transitive), so this is a surgical importer
entry. Validated with `pnpm install --frozen-lockfile` on pnpm 10.23.0 → passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@webdevtodayjason webdevtodayjason merged commit 14c7663 into main Jun 4, 2026
15 of 16 checks passed
@webdevtodayjason webdevtodayjason deleted the hotfix-main-2026.5.6.7 branch June 4, 2026 17:45
webdevtodayjason added a commit that referenced this pull request Jun 4, 2026
Mirror of the fix promoted to main via #433. dev still carried the drift from
v2026.5.6.7 (@noble/ed25519 added to root package.json without regenerating the
root importer in pnpm-lock.yaml), so a release cut from dev would re-break
frozen-lockfile CI. Surgical importer entry; validated with
`pnpm install --frozen-lockfile` (pnpm 10.23.0).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant