Skip to content

Feature added clm demo#94

Open
jgozner wants to merge 20 commits into
mainfrom
feature-added-clm-demo
Open

Feature added clm demo#94
jgozner wants to merge 20 commits into
mainfrom
feature-added-clm-demo

Conversation

@jgozner

@jgozner jgozner commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Description

Added a code sample that showcases CLM workflow leveraging templates with Apryse WebViewer

Checklist

  • I understand that this is a public repo and my changes will be publicly visible

If you are adding a new sample

  • I have added an entry to the root level README
  • The name of my sample is consistent with the other samples
  • I have added a README to my sample
  • The sample is fully functional
  • I have updated lerna.json with the new sample name

If you are removing an old sample

  • I have removed the entry from the root level README
  • I have removed the sample from lerna.json

@DavidEGutierrez DavidEGutierrez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Project overall looks good. There are a number of flags coming from the automated quality tool SonarQube that need to be addressed.

92 issues

9.3% Duplication

C Reliability Rating on New Code

Resolution Attempt

Leveraging Coding Agent to resolve then will request @jgozner approval on this sub-branch.

@copilot Create a new branch called feature-added-clm-demo-sonarqube-resolution based off of feature-added-clm-demo branch. Take a look at each of the issues reported by SonarQube listed in this PR as failing the quality gates and try to resolve. Then, create a new PR for the changes from feature-added-clm-demo-sonarqube-resolution into feature-added-clm-demo.

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

@DavidEGutierrez I've opened a new pull request, #95, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits May 13, 2026 20:28
Comment thread webviewer-clm/src/pages/agreements/create.tsx Outdated
Comment thread webviewer-clm/src/pages/templates/create.tsx Outdated
Comment thread webviewer-clm/src/pages/templates/edit.tsx Outdated
Comment thread webviewer-clm/package.json Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please consider the followings:

  • License key value (in three places) to be replaced by 'YOUR_LICENSE_KEY'
  • name property in package.json to value "webviewer-clm"

Copilot AI and others added 5 commits May 15, 2026 12:53
…package to webviewer-clm

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…ix XSS and arbitrary file read vulnerabilities

Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/b8ec9fcf-141d-4039-aee6-593a2df37578

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…E, <= 11.8.0)

Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/b8ec9fcf-141d-4039-aee6-593a2df37578

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Address SonarQube reliability/type findings in CLM sample flows

@DavidEGutierrez DavidEGutierrez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot attempt to fix the reported issues:

Resolve each of the findings reported as failing from SonarQube. Do not attempt to connect to SonarQube as there is a firewall and you cannot query it to get the failing quality gate issues. However in the files changed, you will see comments from SonarQube already in this PR that will indicate what the issues is with each file.

…eclarations

Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/35747b14-04cf-4ab8-acc2-57adc4d87a7c

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…s, var declarations"

This reverts commit 6205042.

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>

@DavidEGutierrez DavidEGutierrez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot the /public/webviewer/lib folder contains files, this folder MUST not be checked, those files are auto-moved using none of those files in the folder should be committed. Remove them. In fact those are copied at build time using the custom script webviewer-clm/tools/copy-webviewer-files.cjs, only for local build, not for repo checkin.

…ts from being committed

Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/f000325a-07e1-437e-a638-9dfad93cc6b6

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>

Copilot AI commented May 15, 2026

Copy link
Copy Markdown
Contributor

@copilot the /public/webviewer/lib folder contains files, this folder MUST not be checked, those files are auto-moved using none of those files in the folder should be committed. Remove them. In fa...

Done — added public/webviewer/lib/ to webviewer-clm/.gitignore in commit 32c17dd. The rule is verified active via git check-ignore; running copy-webviewer-files.cjs locally no longer causes those files to appear as untracked. The rest of the committed files are unchanged.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.refine.dev
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/webviewer-samples/webviewer-samples/webviewer-clm/node_modules/.bin/refine build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@DavidEGutierrez DavidEGutierrez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot create a new sub-branch to commit the issues raised in feature-added-clm-demo
and create a PR assigned to me. Fix the follow issues:

  1. Duplicated lines per SonarQube
    webviewer-clm/src/pages/blog-posts/create.tsx 75.3% duplicated lines
    webviewer-clm/src/pages/blog-posts/edit.tsx 68.8% duplicated lines
    webviewer-clm/src/AppContent.tsx 39.2% duplicated lines
    webviewer-clm/src/App.tsx 26.2% duplicated lines

  2. Do not use "Math" to declare a variable - use another name
    webviewer-clm/src/pages/agreements/create.tsx

  3. Unsafe usage of optional chaining. If it short-circuits with 'undefined' the evaluation will throw TypeError
    webviewer-clm/src/pages/templates/create.tsx

Copilot AI commented May 15, 2026

Copy link
Copy Markdown
Contributor

@DavidEGutierrez I've opened a new pull request, #96, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 4 commits May 15, 2026 18:47
…ation

Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/8353866d-f627-416e-9644-15f8f3337803

Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Address CLM review feedback: deduplicate routes/forms, fix agreement variable declarations, and harden template create null checks
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
57 New issues

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants