Feature added clm demo#94
Conversation
DavidEGutierrez
left a comment
There was a problem hiding this comment.
Summary
Project overall looks good. There are a number of flags coming from the automated quality tool SonarQube that need to be addressed.
C Reliability Rating on New Code
Resolution Attempt
Leveraging Coding Agent to resolve then will request @jgozner approval on this sub-branch.
@copilot Create a new branch called feature-added-clm-demo-sonarqube-resolution based off of feature-added-clm-demo branch. Take a look at each of the issues reported by SonarQube listed in this PR as failing the quality gates and try to resolve. Then, create a new PR for the changes from feature-added-clm-demo-sonarqube-resolution into feature-added-clm-demo.
|
@DavidEGutierrez I've opened a new pull request, #95, to work on those changes. Once the pull request is ready, I'll request review from you. |
Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/4a8541ca-c9e7-41ee-aa74-6d8e4306d442 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/4a8541ca-c9e7-41ee-aa74-6d8e4306d442 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Mohammed-AbdulRahman-Apryse
left a comment
There was a problem hiding this comment.
Looks good. Please consider the followings:
- License key value (in three places) to be replaced by 'YOUR_LICENSE_KEY'
- name property in package.json to value "webviewer-clm"
…package to webviewer-clm Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/b8ec9fcf-141d-4039-aee6-593a2df37578 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…ix XSS and arbitrary file read vulnerabilities Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/b8ec9fcf-141d-4039-aee6-593a2df37578 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…E, <= 11.8.0) Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/b8ec9fcf-141d-4039-aee6-593a2df37578 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Address SonarQube reliability/type findings in CLM sample flows
DavidEGutierrez
left a comment
There was a problem hiding this comment.
@copilot attempt to fix the reported issues:
Resolve each of the findings reported as failing from SonarQube. Do not attempt to connect to SonarQube as there is a firewall and you cannot query it to get the failing quality gate issues. However in the files changed, you will see comments from SonarQube already in this PR that will indicate what the issues is with each file.
…eclarations Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/35747b14-04cf-4ab8-acc2-57adc4d87a7c Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…s, var declarations" This reverts commit 6205042. Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
DavidEGutierrez
left a comment
There was a problem hiding this comment.
@copilot the /public/webviewer/lib folder contains files, this folder MUST not be checked, those files are auto-moved using none of those files in the folder should be committed. Remove them. In fact those are copied at build time using the custom script webviewer-clm/tools/copy-webviewer-files.cjs, only for local build, not for repo checkin.
…ts from being committed Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/f000325a-07e1-437e-a638-9dfad93cc6b6 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Done — added Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
DavidEGutierrez
left a comment
There was a problem hiding this comment.
@copilot create a new sub-branch to commit the issues raised in feature-added-clm-demo
and create a PR assigned to me. Fix the follow issues:
-
Duplicated lines per SonarQube
webviewer-clm/src/pages/blog-posts/create.tsx 75.3% duplicated lines
webviewer-clm/src/pages/blog-posts/edit.tsx 68.8% duplicated lines
webviewer-clm/src/AppContent.tsx 39.2% duplicated lines
webviewer-clm/src/App.tsx 26.2% duplicated lines -
Do not use "Math" to declare a variable - use another name
webviewer-clm/src/pages/agreements/create.tsx -
Unsafe usage of optional chaining. If it short-circuits with 'undefined' the evaluation will throw TypeError
webviewer-clm/src/pages/templates/create.tsx
|
@DavidEGutierrez I've opened a new pull request, #96, to work on those changes. Once the pull request is ready, I'll request review from you. |
Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/412f218e-3857-49d3-8ab3-6349e37df6e5 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
…ation Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/8353866d-f627-416e-9644-15f8f3337803 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ApryseSDK/webviewer-samples/sessions/8353866d-f627-416e-9644-15f8f3337803 Co-authored-by: DavidEGutierrez <172812369+DavidEGutierrez@users.noreply.github.com>
Address CLM review feedback: deduplicate routes/forms, fix agreement variable declarations, and harden template create null checks
|




Description
Added a code sample that showcases CLM workflow leveraging templates with Apryse WebViewer
Checklist
If you are adding a new sample
lerna.jsonwith the new sample nameIf you are removing an old sample
lerna.json