Skip to content

Martin/svr 6891 enhance xliff rtl samples obj c python php ruby go#211

Draft
mrmartinclark wants to merge 6 commits into
masterfrom
martin/SVR-6891-enhance-xliff-rtl-samples-obj-c-python-php-ruby-go
Draft

Martin/svr 6891 enhance xliff rtl samples obj c python php ruby go#211
mrmartinclark wants to merge 6 commits into
masterfrom
martin/SVR-6891-enhance-xliff-rtl-samples-obj-c-python-php-ruby-go

Conversation

@mrmartinclark
Copy link
Copy Markdown
Contributor

Description

This pull request adds new language-specific translation test samples for Arabic and Hebrew to the project, ensuring that these new samples are consistently included across build configurations, sample lists, and Visual Studio solution files.

Additionally, it introduces new XLIFF2 test files using a French translation.

Context/Why?

N/A

Implementation notes

Used the existing TransPDFTest as a base for the new Samples and the Confluence document here for reference purposes.

How to verify

Build and run the necessary tests.

Changelog entry

N/A

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds new TransPDF translation sample/test assets for Arabic and Hebrew across multiple wrapper languages, and introduces an additional XLIFF 2.0 French test file for the existing TransPDF sample flow.

Changes:

  • Added new TransPDFTestArabic and TransPDFTestHebrew samples for Ruby/Python/PHP/Go.
  • Added new Arabic/Hebrew XLIFF 1.2 translation files and a French XLIFF 2.0 test file.
  • Updated existing TransPDFTest samples and Alpine Go Jenkins job to account for new translation/XLIFF usage.

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Samples/TransPDFTestHebrew/RUBY/TransPDFTestHebrew.rb New Ruby Hebrew TransPDF translation sample.
Samples/TransPDFTestHebrew/RUBY/RunTest.sh New Unix runner script for Ruby Hebrew sample.
Samples/TransPDFTestHebrew/RUBY/RunTest.bat New Windows runner script for Ruby Hebrew sample.
Samples/TransPDFTestHebrew/PYTHON/TransPDFTestHebrew.py New Python Hebrew TransPDF translation sample.
Samples/TransPDFTestHebrew/PHP/TransPDFTestHebrew.php New PHP Hebrew TransPDF translation sample.
Samples/TransPDFTestHebrew/PHP/RunTest.sh New Unix runner script for PHP Hebrew sample.
Samples/TransPDFTestHebrew/PHP/RunTest.bat New Windows runner script for PHP Hebrew sample.
Samples/TransPDFTestHebrew/GO/TransPDF_test_hebrew.go New Go Hebrew TransPDF test sample.
Samples/TransPDFTestArabic/RUBY/TransPDFTestArabic.rb New Ruby Arabic TransPDF translation sample.
Samples/TransPDFTestArabic/RUBY/RunTest.sh New Unix runner script for Ruby Arabic sample.
Samples/TransPDFTestArabic/RUBY/RunTest.bat New Windows runner script for Ruby Arabic sample.
Samples/TransPDFTestArabic/PYTHON/TransPDFTestArabic.py New Python Arabic TransPDF translation sample.
Samples/TransPDFTestArabic/PHP/TransPDFTestArabic.php New PHP Arabic TransPDF translation sample.
Samples/TransPDFTestArabic/PHP/RunTest.sh New Unix runner script for PHP Arabic sample.
Samples/TransPDFTestArabic/PHP/RunTest.bat New Windows runner script for PHP Arabic sample.
Samples/TransPDFTestArabic/GO/TransPDF_test_arabic.go New Go Arabic TransPDF test sample.
Samples/TransPDFTest/RUBY/TransPDFTest.rb Adds a commented XLIFF2 usage hint for Ruby TransPDFTest.
Samples/TransPDFTest/RUBY/RunTest.sh Updates Ruby runner script (currently breaks TransPDFTest execution).
Samples/TransPDFTest/PYTHON/TransPDFTest.py Adds a commented XLIFF2 usage hint (currently invalid Python syntax).
Samples/TransPDFTest/PHP/TransPDFTest.php Adds a commented XLIFF2 usage hint for PHP.
Samples/TransPDFTest/GO/TransPDF_test.go Adds a commented XLIFF2 usage hint (currently invalid Go example).
Samples/TestFiles/translation-test-(en_to_he).xlf Adds Hebrew translation XLIFF 1.2 test file.
Samples/TestFiles/translation-test-(en_to_ar).xlf Adds Arabic translation XLIFF 1.2 test file.
Samples/TestFiles/find-replace-test_(en_to_fr)-2.xlf Adds French XLIFF 2.0 test file for existing sample.
jenkinsfiles/build_alpine_go.groovy Adjusts Alpine Go CI sample execution (currently removes new samples and reruns tests multiple times).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Samples/TransPDFTest/RUBY/RunTest.sh Outdated
Comment thread Samples/TransPDFTest/PYTHON/TransPDFTest.py Outdated
Comment thread Samples/TransPDFTest/GO/TransPDF_test.go Outdated
Comment thread jenkinsfiles/build_alpine_go.groovy Outdated
Comment thread Samples/TransPDFTestArabic/PYTHON/TransPDFTestArabic.py Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 24 out of 25 changed files in this pull request and generated 7 comments.

Comment thread Samples/TransPDFArabicTest/GO/TransPDFArabic_test.go
Comment thread Samples/TransPDFHebrewTest/GO/TransPDFHebrew_test.go
Comment thread jenkinsfiles/build_alpine_go.groovy Outdated
Comment thread Samples/TestFiles/translation-test-(en_to_he).xlf Outdated
Comment thread Samples/TransPDFTest/RUBY/TransPDFTest.rb Outdated
Comment thread Samples/TransPDFTest/PYTHON/TransPDFTest.py Outdated
Comment thread Samples/TransPDFTest/PHP/TransPDFTest.php Outdated
@mrmartinclark mrmartinclark marked this pull request as draft June 5, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants