Martin/svr 6891 enhance xliff rtl samples obj c python php ruby go#211
Draft
mrmartinclark wants to merge 6 commits into
Draft
Martin/svr 6891 enhance xliff rtl samples obj c python php ruby go#211mrmartinclark wants to merge 6 commits into
mrmartinclark wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds new TransPDF translation sample/test assets for Arabic and Hebrew across multiple wrapper languages, and introduces an additional XLIFF 2.0 French test file for the existing TransPDF sample flow.
Changes:
- Added new TransPDFTestArabic and TransPDFTestHebrew samples for Ruby/Python/PHP/Go.
- Added new Arabic/Hebrew XLIFF 1.2 translation files and a French XLIFF 2.0 test file.
- Updated existing TransPDFTest samples and Alpine Go Jenkins job to account for new translation/XLIFF usage.
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/TransPDFTestHebrew/RUBY/TransPDFTestHebrew.rb | New Ruby Hebrew TransPDF translation sample. |
| Samples/TransPDFTestHebrew/RUBY/RunTest.sh | New Unix runner script for Ruby Hebrew sample. |
| Samples/TransPDFTestHebrew/RUBY/RunTest.bat | New Windows runner script for Ruby Hebrew sample. |
| Samples/TransPDFTestHebrew/PYTHON/TransPDFTestHebrew.py | New Python Hebrew TransPDF translation sample. |
| Samples/TransPDFTestHebrew/PHP/TransPDFTestHebrew.php | New PHP Hebrew TransPDF translation sample. |
| Samples/TransPDFTestHebrew/PHP/RunTest.sh | New Unix runner script for PHP Hebrew sample. |
| Samples/TransPDFTestHebrew/PHP/RunTest.bat | New Windows runner script for PHP Hebrew sample. |
| Samples/TransPDFTestHebrew/GO/TransPDF_test_hebrew.go | New Go Hebrew TransPDF test sample. |
| Samples/TransPDFTestArabic/RUBY/TransPDFTestArabic.rb | New Ruby Arabic TransPDF translation sample. |
| Samples/TransPDFTestArabic/RUBY/RunTest.sh | New Unix runner script for Ruby Arabic sample. |
| Samples/TransPDFTestArabic/RUBY/RunTest.bat | New Windows runner script for Ruby Arabic sample. |
| Samples/TransPDFTestArabic/PYTHON/TransPDFTestArabic.py | New Python Arabic TransPDF translation sample. |
| Samples/TransPDFTestArabic/PHP/TransPDFTestArabic.php | New PHP Arabic TransPDF translation sample. |
| Samples/TransPDFTestArabic/PHP/RunTest.sh | New Unix runner script for PHP Arabic sample. |
| Samples/TransPDFTestArabic/PHP/RunTest.bat | New Windows runner script for PHP Arabic sample. |
| Samples/TransPDFTestArabic/GO/TransPDF_test_arabic.go | New Go Arabic TransPDF test sample. |
| Samples/TransPDFTest/RUBY/TransPDFTest.rb | Adds a commented XLIFF2 usage hint for Ruby TransPDFTest. |
| Samples/TransPDFTest/RUBY/RunTest.sh | Updates Ruby runner script (currently breaks TransPDFTest execution). |
| Samples/TransPDFTest/PYTHON/TransPDFTest.py | Adds a commented XLIFF2 usage hint (currently invalid Python syntax). |
| Samples/TransPDFTest/PHP/TransPDFTest.php | Adds a commented XLIFF2 usage hint for PHP. |
| Samples/TransPDFTest/GO/TransPDF_test.go | Adds a commented XLIFF2 usage hint (currently invalid Go example). |
| Samples/TestFiles/translation-test-(en_to_he).xlf | Adds Hebrew translation XLIFF 1.2 test file. |
| Samples/TestFiles/translation-test-(en_to_ar).xlf | Adds Arabic translation XLIFF 1.2 test file. |
| Samples/TestFiles/find-replace-test_(en_to_fr)-2.xlf | Adds French XLIFF 2.0 test file for existing sample. |
| jenkinsfiles/build_alpine_go.groovy | Adjusts Alpine Go CI sample execution (currently removes new samples and reruns tests multiple times). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds new language-specific translation test samples for Arabic and Hebrew to the project, ensuring that these new samples are consistently included across build configurations, sample lists, and Visual Studio solution files.
Additionally, it introduces new XLIFF2 test files using a French translation.
Context/Why?
N/A
Implementation notes
Used the existing TransPDFTest as a base for the new Samples and the Confluence document here for reference purposes.
How to verify
Build and run the necessary tests.
Changelog entry
N/A