fix (Meatballs util): Inconsistent behavior in individual post blog view - #2389
Open
marcustyphoon wants to merge 1 commit into
Open
marcustyphoon wants to merge 1 commit into
marcustyphoon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The meatballs util currently adds menu items to the blog menus atop blog view pages when viewing a blog's post, but not to the basically identical one in the sidebar of blog view pages when viewing a specific post. This fixes this discrepancy.
Screenshots
Testing steps
This can only be tested by merging the mute PR on top of this, as we don't use registerBlogMeatballItem currently.
Enable the mute feature and confirm that a mute menu item is added to the blog menus in https://www.tumblr.com/april, https://www.tumblr.com/april/661324787743948800 in both directly-navigated-to and glass modal versions.