Skip to content

fix(windows): resolve the update check and fix the unreadable Update-failed badge#437

Open
davidbudnick wants to merge 2 commits into
AprilNEA:masterfrom
davidbudnick:fix/windows-update-check-and-badge
Open

fix(windows): resolve the update check and fix the unreadable Update-failed badge#437
davidbudnick wants to merge 2 commits into
AprilNEA:masterfrom
davidbudnick:fix/windows-update-check-and-badge

Conversation

@davidbudnick

@davidbudnick davidbudnick commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes two Windows-facing bugs in the Updates page:

  1. The update check always fails. The Windows client fetches channels/stable/latest.json and matches os=windows / arch=x86_64 / format=msi, but the published manifest was dmg-only — so the check errored with "no release asset matched the current platform (windows/x86_64)" instead of resolving. The manifest omitted Windows because xtask release latest-json was invoked without --include-windows and the R2 upload excluded the zip/msi.
  2. The "Update failed" status pill is unreadable. The OpenLogi Dark theme set danger.foreground to red-600 over a danger.background of #ef4444 (red-500) — dark-red text on a red fill.

This keeps Windows notify-only (the client stays INSTALL_SUPPORTED=false): a resolved check surfaces "Update available" and routes to the GitHub Release for the download rather than auto-installing. The in-app MSI install flow (gpui-updater's staged msiexec) remains switched off — that's separate work.

Changes

release / xtask.github/workflows/release.yml, xtask/src/commands/release/latest_json.rs:

  • Pass --include-windows to xtask release latest-json so the manifest carries the per-arch .msi/.zip entries.
  • Stop the R2 upload from excluding *.zip/*.msi and their .minisigs, so the asset + signature URLs the manifest now advertises resolve instead of 404ing (*.exe stays excluded defensively — no bare exe ships).
  • Refresh the now-stale --include-windows doc comment.

guicrates/openlogi-gui/themes/openlogi.json:

  • Dark-theme danger.foreground red-600neutral-50, matching the light theme's danger treatment.

Testing

Not runtime-tested — these are release-pipeline and theme-data changes:

  • The manifest fix only takes effect on the next tagged release; the currently-published latest.json is unaffected. It can be validated before tagging by running the generator against a populated dist/ and confirming the windows/x86_64/msi entry appears: cargo run -p xtask -- release latest-json --dist dist --tag vX.Y.Z --base-url https://updates.openlogi.org --include-windows --output dist/latest.json
  • The theme change is a JSON data edit (validated as well-formed); the pill renders near-white on red in dark mode.

…ecks resolve

The Windows client fetches channels/stable/latest.json and matches
os=windows/arch=x86_64/format=msi, but the manifest shipped dmg-only, so
the check failed with "no release asset matched the current platform
(windows/x86_64)" instead of resolving.

Pass --include-windows to `xtask release latest-json` so the manifest
carries the per-arch msi/zip entries, and stop the R2 upload step from
excluding the zip/msi (and their minisigs) so the asset/signature URLs
the manifest now advertises resolve instead of 404ing.

This is notify-only: the client stays INSTALL_SUPPORTED=false on Windows,
so a resolved check surfaces "Update available" and routes to the GitHub
Release for the download rather than auto-installing.
The OpenLogi Dark theme set danger.foreground to red-600 over a
danger.background of #ef4444 (red-500) — dark-red text on a red fill,
which rendered the "Update failed" status pill (and every other filled
danger tag) essentially unreadable. Use neutral-50, matching the light
theme's danger treatment, for legible near-white-on-red.
@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes Windows update checks and improves the failed-update badge. The main changes are:

  • Adds Windows MSI and ZIP entries to the release manifest.
  • Uploads Windows artifacts and signatures to R2.
  • Uses a light foreground for the dark-theme danger badge.
  • Updates the Windows manifest option documentation.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
.github/workflows/release.yml Enables Windows manifest entries and uploads their MSI, ZIP, and signature files.
crates/openlogi-gui/themes/openlogi.json Changes the dark-theme danger foreground to a readable light neutral color.
xtask/src/commands/release/latest_json.rs Updates documentation for the existing Windows manifest option.

Reviews (1): Last reviewed commit: "fix(gui): make the dark-theme danger tag..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant