fix(windows): resolve the update check and fix the unreadable Update-failed badge#437
Open
davidbudnick wants to merge 2 commits into
Open
fix(windows): resolve the update check and fix the unreadable Update-failed badge#437davidbudnick wants to merge 2 commits into
davidbudnick wants to merge 2 commits into
Conversation
…ecks resolve The Windows client fetches channels/stable/latest.json and matches os=windows/arch=x86_64/format=msi, but the manifest shipped dmg-only, so the check failed with "no release asset matched the current platform (windows/x86_64)" instead of resolving. Pass --include-windows to `xtask release latest-json` so the manifest carries the per-arch msi/zip entries, and stop the R2 upload step from excluding the zip/msi (and their minisigs) so the asset/signature URLs the manifest now advertises resolve instead of 404ing. This is notify-only: the client stays INSTALL_SUPPORTED=false on Windows, so a resolved check surfaces "Update available" and routes to the GitHub Release for the download rather than auto-installing.
The OpenLogi Dark theme set danger.foreground to red-600 over a danger.background of #ef4444 (red-500) — dark-red text on a red fill, which rendered the "Update failed" status pill (and every other filled danger tag) essentially unreadable. Use neutral-50, matching the light theme's danger treatment, for legible near-white-on-red.
Greptile SummaryThis PR fixes Windows update checks and improves the failed-update badge. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(gui): make the dark-theme danger tag..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two Windows-facing bugs in the Updates page:
channels/stable/latest.jsonand matchesos=windows/arch=x86_64/format=msi, but the published manifest was dmg-only — so the check errored with "no release asset matched the current platform (windows/x86_64)" instead of resolving. The manifest omitted Windows becausextask release latest-jsonwas invoked without--include-windowsand the R2 upload excluded the zip/msi.danger.foregroundtored-600over adanger.backgroundof#ef4444(red-500) — dark-red text on a red fill.This keeps Windows notify-only (the client stays
INSTALL_SUPPORTED=false): a resolved check surfaces "Update available" and routes to the GitHub Release for the download rather than auto-installing. The in-app MSI install flow (gpui-updater's stagedmsiexec) remains switched off — that's separate work.Changes
release / xtask —
.github/workflows/release.yml,xtask/src/commands/release/latest_json.rs:--include-windowstoxtask release latest-jsonso the manifest carries the per-arch.msi/.zipentries.*.zip/*.msiand their.minisigs, so the asset + signature URLs the manifest now advertises resolve instead of 404ing (*.exestays excluded defensively — no bare exe ships).--include-windowsdoc comment.gui —
crates/openlogi-gui/themes/openlogi.json:danger.foregroundred-600→neutral-50, matching the light theme's danger treatment.Testing
Not runtime-tested — these are release-pipeline and theme-data changes:
latest.jsonis unaffected. It can be validated before tagging by running the generator against a populateddist/and confirming thewindows/x86_64/msientry appears:cargo run -p xtask -- release latest-json --dist dist --tag vX.Y.Z --base-url https://updates.openlogi.org --include-windows --output dist/latest.json