Repository navigation
bugfix - the function healthy? should not overwrite default policy's totalTimeout - #74
Draft
lily-a-dev wants to merge 17 commits into
Draft
lily-a-dev wants to merge 17 commits into
lily-a-dev wants to merge 17 commits into
Conversation
`com.aerospike.client.policy.Policy` instead of an `operation-timeout-ms` integer. The 1-arity default behavior is unchanged (totalTimeout of 1000ms), but callers using the 2-arity must now pass a pre-built `Policy` object.
…n-timeout-ms` integer for health checks, replacing the previous `Policy` parameter. Updated health check logic to prevent zero TTL for small timeouts. Enhanced client configuration to allow `:health-policy` for customizable read policies without shared state mutation.
added 2 commits
March 26, 2026 15:42
…ing a policy obj. 2. Added a helper function
lily-a-dev
marked this pull request as draft
March 26, 2026 15:02
added 6 commits
March 26, 2026 18:37
…f `:health-config`. If health-policy is abset, use the client policy. Updated documentation and tutorial to reflect changes in health policy initialization. Removed deprecated health policy creation function and adjusted related tests for consistency.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
BREAKING:
AerospikeAdminOps/healthy?now relies on the client'sinitialized health policy (default total timeout: 1000ms) instead of accepting
a timeout override per call. This removes mutation of the shared
readPolicyDefaulton the underlyingAerospikeClient, which previouslycould permanently overwrite the configured
totalTimeout.Fixed a health check regression: the write TTL now uses
max 1when derivingTTL from
:totalTimeout, so very small timeouts no longer produce a0TTL (which could skip retention and make checks flaky).
Changed
AerospikeAdminOps/healthy?protocol now exposes only the zero-arityhealthy? [this]contract. Timeout customization is configured at clientinitialization via
:health-policyinstead of through the protocol call.init-simple-aerospike-clientnow accepts:health-policyin itsconfmap as string-keyed read-policy overrides. The configured value is applied on
top of the resolved client policy's
readPolicyDefault, with a default{\"totalTimeout\" 1000}fallback. This makes health check behaviorconfigurable per client without mutating any shared default policy object.