Repository navigation
feat: revamp math equations with Flutter parity and Figma design - #645
Merged
Merged
Conversation
added 15 commits
October 18, 2026 20:21
annieappflowy
marked this pull request as ready for review
October 20, 2026 07:44
|
Sorry @annieappflowy, your pull request is larger than the review limit of 150,000 diff characters |
appflowy
pushed a commit
that referenced
this pull request
Oct 20, 2026
* Port Flutter math equations and Figma editor to web * Match Figma math interactions and complete Flutter parity coverage * Refine equation selection, menus, and editor controls * Preserve database text cell equation toolbar behavior * Fix equation menu interactions and block mention titles * Fix math shortcut focus and match Flutter placeholder * Fix equation menu anchoring and repeated shortcut focus * Fix equation rendering, mention lifecycle, and inline focus * Rename math block to Block equation and preserve slash aliases * Add block equation slash search abbreviations * Add eqn slash search alias for inline equations * Prevent vertical scrolling inside auto-sized equation blocks * Match equation content-to-action spacing to Figma * Match Flutter equation AI loading and render Markdown responses * Match Flutter equation AI stop control size --------- Co-authored-by: Annie Wang <anniew@MacBook-Pro-2.local> (cherry picked from commit c646104) Conflict in SlashPanel.tsx: kept #645's inline equation imports (flushSync, insertInlineEquation) and dropped the atomic block-creation-target import this branch removes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
appflowy
added a commit
that referenced
this pull request
Oct 20, 2026
main gained #645, which this branch already has as a cherry-pick. In SlashPanel.tsx, keep this branch's imports: main's copy still imports the atomic block-creation-target helpers this PR removes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Math equations now support Flutter's block and inline editing flows in Web, with the editor and action menus rebuilt against the Figma math showcase. Pasting math Markdown creates equations while preserving the original TeX.
Changes
math equation,me,blk,be, andeqnas slash-menu aliases alongside existing math/TeX search terms. The sharedeqnalias also finds Inline equation while preserving its existing search terms.$$, including while the toolbar bundle is still loading or the converted block DOM is committing. Release Slate’s focus state while the TeX input is active so saving returns keyboard focus to the document and repeated$$insertion works; keep other block popover contents loaded on demand. Port inline/block shortcuts, whole-string IME input, selection-toolbar formatting, Cmd/Ctrl+Shift+E, inline error previews, continued typing, undo/redo, and read-only behavior. Inline editing explicitly hands focus from Slate to the popover. Cancellation keeps editor mutations outside React state updaters and unmounts the popover focus trap before restoring the cursor; tracked ranges are released on cancellation and unmount.latex,tex, andmathfences to equations for both preview and insertion, including nested Markdown math wrappers; retain explicit Insert and late-response/collaborator guards.Validation
$$typing, inline cancellation and continued typing, exact dimensions and viewport bounds, hover/selection cleanup, parent/submenu placement and dismissal, empty AI actions, copied-block mentions, paste/reload, toolbar/keyboard conversion, undo/redo, and mocked AI streaming/insertion.$$typing.git diff --check, and production build passed.$$insertion and focus restoration, six-dot positioning against other blocks, save/reload, and hover cleanup. A subsequent live Explain equation request through the configured test-cloud backend returned HTTP 200 and rendered 61 equations and 16 list items without TeX errors or horizontal overflow. The response area remained bounded at 440 px. Browser automation uses controlled AI responses; the live check reviewed the response without inserting it into the user’s document. Console observations were limited to the existing disabled-tooltip warning and the hover-control “No range and node found” warning; no AI rendering error was observed.Compatibility and limits
Closed-issue audit
Reviewed the 13 closed editor issues returned by the equation search. The tested scenarios in AppFlowy #8312, #6053, #7399, #6411, #6986, #7279, #7331, and #1066 are supported.
Remaining limitations:
$x_1$becoming a plain$. Pasting the same Markdown preserves both forms. This import-path gap is not fixed here.