Repository navigation
fix(updates): verify signing compatibility before release - #70
Merged
Merged
Conversation
appflowy
marked this pull request as ready for review
October 29, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.14.7 → 0.14.11 macOS update is rejected because the released 0.14.11 app omits
SUPublicEDKey. Its DMG signature, Apple code signature and notarization all pass, but Sparkle explicitly rejects removal of the key. Desktop #1481 removed it; Desktop #1533 has already restored it on main. Corrected macOS installers still need to be built and published.This change validates the actual macOS bundle and compiled Windows public-key resource before packaging, then checks final installer signatures against the public keys verified in the released 0.14.7 clients. It verifies release asset hashes, Windows Authenticode and installer versions, and macOS code signing/notarization before producing update feeds. Both legacy and native feed filenames remain supported. Windows retains DSA/SHA1 compatibility with deployed WinSparkle clients. The Windows build also moves its two obsolete setup actions to supported equivalents, preserving Rust 1.92.0.
Validation:
SearchEvidencePB,SearchEvidenceKindPB,ExportWorkspaceRequestPB.localImageDirectory). No app settings were changed.This PR does not replace installers, upload feeds, or publish a release. The live release also lacks an Intel macOS appcast and all native-generation feeds. Publish the selected feed artifacts only after corrected installers are available and validated. Full application upgrade/install smoke tests remain a release validation step.