fix: update model registry to Opus 4.8 and fix re-auth spinner - #2024
fix: update model registry to Opus 4.8 and fix re-auth spinner#2024DudiPeretz-Orca wants to merge 1 commit into
Conversation
- Upgrade `opus`/`opus-1m` shorthands to resolve to `claude-opus-4-8` (current flagship) across AVAILABLE_MODELS, ALL_AVAILABLE_MODELS, MODEL_ID_MAP, DEFAULT_MODEL_EQUIVALENCES, and the main-process mirror in ai/config/types.ts - Add `opus-4.6` as a selectable legacy entry so users who need the prior model can still access it - Add `claude-opus-4-8` to ADAPTIVE_THINKING_MODELS in types.ts - Fix re-auth spinner never clearing: replace clearProfileUsageCache() with clearAuthFailedProfile() in the CLAUDE_AUTH_LOGIN_SUBPROCESS success handler so needsReauthProfiles is properly cleared Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
|
👋 Thanks so much for your interest in contributing to Aperant! Pull requests are currently paused. We're rebuilding the entire app from the ground up for Aperant 3.0 (including new cloud features), so changes against the current codebase can't be merged — they'd be overwritten by the rewrite. Most of the 3.0 work is happening in a separate development repo right now and will be merged here once it's ready — so although this repo looks quiet, the project is very much alive. 🚀 We're closing this PR for now, but we'd genuinely love your help shaping 3.0:
This is temporary — contributions will reopen once the 3.0 foundation lands. Thank you for understanding! 🙏 |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughPromotes ChangesOpus 4.8 promotion and auth cache fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🎉 Thanks for your first PR!
A maintainer will review it soon. Please make sure:
- Your branch is synced with
develop - CI checks pass
- You've followed our contribution guide
Welcome to the Auto Claude community!
There was a problem hiding this comment.
Code Review
This pull request updates the model configurations to introduce Claude Opus 4.8 as the default 'opus' and 'opus-1m' model, while transitioning Claude Opus 4.6 to a legacy 'opus-4.6' option. It also updates the re-authentication flow to clear the auth-failed profile cache. The review comments, which should both be addressed, point out that the re-authentication fix needs to be applied to the CLAUDE_PROFILE_VERIFY_AUTH handler as well, and that the new legacy opus-4.6 model should be added to ADAPTIVE_THINKING_MODELS and FAST_MODE_MODELS to ensure its capabilities are fully recognized.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| clearKeychainCache(expandedConfigDir); | ||
| const usageMonitor = getUsageMonitor(); | ||
| usageMonitor.clearProfileUsageCache(profileId); | ||
| usageMonitor.clearAuthFailedProfile(profileId); |
There was a problem hiding this comment.
While this correctly fixes the re-auth spinner issue for the subprocess login flow, the same bug exists in the CLAUDE_PROFILE_VERIFY_AUTH handler at line 1404, which still calls usageMonitor.clearProfileUsageCache(profileId) instead of usageMonitor.clearAuthFailedProfile(profileId). Users authenticating via the embedded terminal flow (which triggers CLAUDE_PROFILE_VERIFY_AUTH) will still experience the persistent spinner/badge bug. Please update line 1404 to use clearAuthFailedProfile(profileId) as well for consistency and correctness.
| { value: 'opus', label: 'Claude Opus 4.8', provider: 'anthropic', description: 'Most capable', capabilities: { thinking: true, tools: true, vision: true, contextWindow: 200000 } }, | ||
| { value: 'opus-1m', label: 'Claude Opus 4.8 (1M)', provider: 'anthropic', description: '1M context', capabilities: { thinking: true, tools: true, vision: true, contextWindow: 1000000 } }, | ||
| { value: 'sonnet', label: 'Claude Sonnet 4.6', provider: 'anthropic', description: 'Balanced', capabilities: { thinking: true, tools: true, vision: true, contextWindow: 200000 } }, | ||
| { value: 'opus-4.6', label: 'Claude Opus 4.6', provider: 'anthropic', description: 'Legacy', capabilities: { thinking: true, tools: true, vision: true, contextWindow: 200000 } }, |
There was a problem hiding this comment.
Since opus-4.6 is added as a legacy selectable model, it should also be included in the ADAPTIVE_THINKING_MODELS and FAST_MODE_MODELS arrays in apps/desktop/src/shared/constants/models.ts (lines 360 and 363) so that the UI and other parts of the application correctly recognize its capabilities (such as adaptive thinking and fast mode support).
Summary
opus/opus-1mshorthands were still resolving toclaude-opus-4-6. Updated across all registry locations (AVAILABLE_MODELS,ALL_AVAILABLE_MODELS,MODEL_ID_MAP,DEFAULT_MODEL_EQUIVALENCES, and the main-process mirror inai/config/types.ts) to useclaude-opus-4-8, the current flagship. Addedopus-4.6as a selectable legacy entry so users who need the prior model can still access it. Addedclaude-opus-4-8toADAPTIVE_THINKING_MODELS.clearProfileUsageCache()which doesn't clearneedsReauthProfiles, the Set that drives the "Re-authentication required" UI badge. Fixed by callingclearAuthFailedProfile()instead, which correctly clears bothauthFailedProfilesandneedsReauthProfiles.Files changed
apps/desktop/src/shared/constants/models.ts— model registry (UI + equivalences)apps/desktop/src/main/ai/config/types.ts— main-process mirror + adaptive thinking setapps/desktop/src/main/ipc-handlers/claude-code-handlers.ts— re-auth success handlerTest plan
claude-opus-4-8npm run typecheck— no errors🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Improvements