Skip to content

More Trading Strategies #1

Description

@yeonholee50

This issue will remain. It is open to all contributors. Please make sure your trading strategy isn't already implemented - this can be checked with a quick scan in strategies in helper/client_helper.py - quick ctrl f

Strategies can be added i neither strategies/trading_strategies_v2.py or strategies/trading_strategies_v2_1.py. Please do not add to trading_strategies_v1.py as those strategies are no longer supported. If you wish you can make a new file titled strategies/trading_strategies_v2_2.py and add your strategies there, but this may require additional import statements to other files. When making your strategy, it must abide by these rules:

  • parameters are ticker, current_price, historical_data, account_cash, portfolio_qty, total_portfolio_value in their respective order
  • return format is action, portfolio_qty, ticker
  • If the portfolio quantity is 0, the only valid action is hold or buy. If sell is returned, then this would confuse the ML.

After adding your strategy, please test it in testing_client.py using test_strategies(). you can add your strategy there to test if it will work. If it does, that is great!. If it passes, please add your strategy name to the strategies list in helper/helper_files. That is it, and you can PR and I'll be happy to take a look.

For people interested in training: to add your strategy to MongoDB with appropriate profile, navigate to ranking_client. Run initialize_rank(). Now your strategy has had its profile made in your MongoDB. you may also need to run insert_rank_to_coefficient to initialize the coefficients so that it's on the format rank - coefficient which will help the trading bot retrieve the required voting coefficient for the current ranking it has. If you have any question about this process or the PR in general, please feel free to contact me

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions