do not merge until OSS will support it - add MASKING POLICY support to RBAC restore#1466
Open
Slach wants to merge 1 commit into
Open
do not merge until OSS will support it - add MASKING POLICY support to RBAC restore#1466Slach wants to merge 1 commit into
Slach wants to merge 1 commit into
Conversation
MASKING POLICY (ClickHouse 25.12+, Cloud-only creation) is a regular access entity stored as <uuid>.sql in access_control_path and in ZooKeeper (prefix char M), so backup side is already type-agnostic. Restore previously failed on such backups because detectRBACObject could not recognize ATTACH MASKING POLICY. - detect ATTACH MASKING POLICY, keep backticks in name (format is `name` ON db.table, same as ROW POLICY) - resolve conflicts via system.masking_policies only on 26.8+ where the table exists, otherwise check local and keeper user directories - drop existing objects in keeper via M prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1332
MASKING POLICY (ClickHouse 25.12+, Cloud-only creation) is a regular access entity stored as .sql in access_control_path and in ZooKeeper (prefix char M), so backup side is already type-agnostic. Restore previously failed on such backups because detectRBACObject could not recognize ATTACH MASKING POLICY.
nameON db.table, same as ROW POLICY)