Repository navigation
Conversation
- openclaw-integration.ts and README: drop CIPHERCLAW_MANIFEST.agents, which the capability manifest does not have. - basic-usage.ts: resolve root causes to CausalNode via getRootCauses() instead of reading .span.name off node-id strings. - Both examples: build Trace/Span/SpanEvent/HierarchyDebugEvent objects with the real field names (attributes, parentSpanId, rootSpanId, propagationPath, ...), use recoverability/predictedFailureType, and null-check report/fingerprint/session results. - Add tsconfig.examples.json and run it from pnpm typecheck so the examples cannot drift from the API again. Closes #6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Both examples crashed at runtime, and the README printed
CIPHERCLAW_MANIFEST.agents(undefined).The crashes reported in the issue were the first of many: the examples were written against an older API shape (
metadatainstead ofattributes,source/target/pathinstead ofsourceAgentId/targetAgentId/propagationPath,recoverable,predictedFailure,errorBreakdown,endTime/startTimeon sessions).tsconfig.jsononly includessrc/, so nothing caught it.Changes:
examples/openclaw-integration.ts,README.md: remove.agentsusage (the capability manifest has skills/tools/events/configuration only).examples/basic-usage.ts: root causes resolved viacc.getRootCauses()(returnsCausalNode[]), printed byoperation.Trace/Span/SpanEvent/HierarchyDebugEvent; nullable returns are checked.tsconfig.examples.json(noEmit, extends tsconfig);pnpm typechecknow also runs it, so CI's existing Type check step covers the examples. No library source changed.Verification (pnpm 9, Node 22):
npx tsx examples/basic-usage.tsexit 0;npx tsx examples/openclaw-integration.tsexit 0pnpm typecheckok,pnpm test270 passed,pnpm buildok🤖 Generated with Claude Code