Repository navigation
Conversation
Hyprland answers "systeminfo" by running lspci on its main thread, which wakes a runtime-suspended dGPU: on hybrid-GPU laptops the first workspace click froze the compositor for over a second. A no-op "eval" is answered "ok" only by the Lua config manager and touches no hardware. Closes Alexays#5286 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
i just tested your fix on 0.57 and it worked for me |
|
Works for me as well on 0.57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The first click on a
hyprland/workspacesbutton resolves the dispatch protocol with asysteminforequest. Hyprland answers it by runninglspci -vnnsynchronously on its main thread (src/helpers/SystemInfo.cpp), and reading the PCI config space of a runtime-suspended discrete GPU wakes it up. On hybrid-GPU laptops the whole compositor freezes until the dGPU has resumed. That matches #5286: the first click freezes the system, later clicks are fine, and it comes back when Waybar restarts. Keybinds and gestures don't go through Waybar, so they never trigger it.This replaces the probe with
eval return nil:evaland answersok.eval is only supported with the lua config manager.evallanded in 0.55 together with the Lua manager, so this still covers a 0.55+ instance started with ahyprland.conf.unknown request.So the result is the same as with the
configProvidercheck. In Lua mode, Hyprland runs adispatchrequest through the sameevalpath, so the probe adds no side effect the click doesn't already have.Measured on Hyprland 0.56.2, Ryzen 5000 (Cezanne) + RTX 3050 Ti Mobile, 3 runs each, starting with the dGPU runtime-suspended:
systeminfoeval return nilisLuaConfigProviderand its tests are replaced byisLuaEvalReply, tested on the replies Hyprland actually sends.Related issues
Closes #5286
Checklist
clang-formatninja -C build),meson testpasseshyprland.lua. The first click switches instantly and the log showsdetected Lua-based dispatch protocol.I reproduced the freeze, tested the fix on my machine, and reviewed the diff. With the help of Claude Code for both the code, and this description.