Repository navigation
Remove the unmaintained CocoaPods, Carthage, Travis and jazzy tooling - #23
Merged
Merged
Conversation
Neither is maintained. The podspec has been stale at 6.3.2 since 2023 and no release has ever carried a Carthage archive, so the Swift Package Manager manifest is the only integration that actually works. The Cartfile also pinned RxSwift 6.5.0, five minor versions behind the manifest, which made it actively misleading.
Travis is not used; the build workflow on GitHub Actions is. The config also referenced an Xcode project name and scripts that no longer exist, and carried an encrypted secret belonging to the upstream repository. Documentation generation could not have succeeded either: .jazzy.yaml named a podspec path that does not exist here, and pointed its module, author and site at upstream. The generated HTML under docs/ was a stale copy of upstream's published reference, which is still served from its own site.
It described bumping a podspec, generating jazzy documentation, building a Carthage archive and pushing to the CocoaPods trunk. None of that happens, and the files it referred to are gone.
all-build.sh and all-tests.sh drive targets and schemes named "RxBluetoothKit iOS", "RxBluetoothKit macOS" and so on. This fork's targets and shared schemes are named RxBluetoothKit_Airthings iOS/macOS/tvOS/watchOS, so both scripts fail on their first command — the same defect the Travis config was removed for. all-tests.sh also pins destinations to iOS 13.6, tvOS 13.4, iPhone 8 and Apple TV 4K. The Carthage and CocoaPods entries in .gitignore have nothing left to ignore now that the manifests are gone.
The requirements block named iOS 9, tvOS 11 and Xcode 11.4 while the manifest requires iOS 12, tvOS 12 and Swift tools 5.9, and the Swift-version table below it stopped at Swift 5.0. Point at Package.swift instead of restating floors that drift. .swift-version, orphaned at 5.0, was only ever read by the CocoaPods and jazzy tooling that is gone. The release note on RxSwift said the bump was breaking and then asked only for a changelog line; say plainly that the version number is the decision. Carthage/Checkouts and Carthage/Build go back into .gitignore: the Xcode project still names that directory, so unlike Pods it is not dead yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift Package Manager manifest is the only integration that works. Everything removed here was either broken or years stale:
6.3.2since 2023, and theCartfilepinned RxSwift6.5.0, five minor versions behind the manifest.travis.ymlnamed an Xcode project and scripts that no longer exist, and carried an encrypted secret belonging to the upstream repositoryscripts/all-build.shandscripts/all-tests.shdrive targets and schemes namedRxBluetoothKit iOS,RxBluetoothKit macOSand so on, but this fork names themRxBluetoothKit_Airthings iOS/macOS/tvOS/watchOS— so both fail on their first command.all-tests.shalso pins destinations to iOS 13.6, tvOS 13.4, iPhone 8 and Apple TV 4K..jazzy.yamlnamed a podspec path that does not exist here, so documentation generation could not have succeeded.swift-version, orphaned at5.0, was only ever read by the CocoaPods and jazzy toolingPodsandPodfile.lockentries in.gitignorehave nothing left to ignoreThe committed
docs/tree is removed because it was out of date: it was generated for6.0.0, under the upstream module name, and documented an API five releases old. GitHub
Pages is not enabled on this repository, so it was never served anywhere — and the
Api referencelink in the README points at the site upstream still publishes, not atdocs/, so that link is unaffected. The doc comments inSource/are untouched, and Xcodesurfaces those directly; a generated reference can be reintroduced with DocC if we want one.
Removing the podspec does not retract the pod versions already published — it only means no new
ones. A consumer referencing the podspec by
:git/:branchrather than through trunk would lose it.Two documentation files also stopped matching the manifest, so they are corrected here: the README
listed iOS 9 / tvOS 11 / Xcode 11.4 against a manifest requiring iOS 12 / tvOS 12 / tools 5.9 and now
points at
Package.swiftinstead of restating floors that drift, andHOW_TO_RELEASE.mdis rewrittento describe what actually happens — changelog, merge, tag, release — and to say plainly that raising
the RxSwift range is what decides the version number.
Worth knowing:
RxBluetoothKit_Airthings.xcodeprojlinks RxSwift, Quick, Nimble and RxTestfrom
$(PROJECT_DIR)/Carthage/Build, so with the Cartfiles gone it can no longer be built at all.It was already unbuildable from a clean clone without an undocumented
carthage bootstrap, and theREADME itself said Carthage stopped working around Xcode 12. Deleting those ~31 references without
replacing them would only make the project fail differently, so the choice — migrate it to SPM
dependencies, or drop it along with
Tests/and the two remaininggenerate-*scripts — is left asits own change. The
Carthage/ignore lines stay for the same reason: that directory is still namedby the project.
Also out of scope, and worth their own change:
scripts/generate-testable.shemits@testable import RxBluetoothKitagainst a module calledRxBluetoothKit_Airthingsand is stillinvoked by three build phases,
scripts/generate-mocks.shdefaults to a removed SDK path, andCHANGELOG.mdstops at6.3.2while the tags run to6.3.6.No source file is touched.
swift buildpasses on both the native and swiftbuild engines.