feat(unity-react-core): modal backdrop close update and custom button… - #1775
Open
spaceperson wants to merge 5 commits into
Open
feat(unity-react-core): modal backdrop close update and custom button…#1775spaceperson wants to merge 5 commits into
spaceperson wants to merge 5 commits into
Conversation
…, state, and children props
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1775/index.html |
davidornelas11
requested changes
Aug 26, 2026
davidornelas11
left a comment
davidornelas11
left a comment
Contributor
There was a problem hiding this comment.
One finding and then this will be good to go. initModals() runs as part of the shared Unity Bootstrap bundle, but this dereferences modal before verifying that modal markup exists. Pages that include the theme without a modal will throw during initialization. return early when the modal, backdrop, or trigger is absent before querying elements or registering listeners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, state, and children props
Description
Checklist
Important Reminders
Links