Skip to content

fix(unity-bootstrap-theme): remove bluefocus artifact that was confus… #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlsamuelson wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(unity-bootstrap-theme): remove bluefocus artifact that was confus… #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .kiro/skills/asu-brand/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ copy of this skill and the Unity-provided CSS variables.)
| ASU Green | `#78be20` | `$uds-color-base-green` |
| ASU Orange | `#ff7f32` | `$uds-color-base-orange` |
| ASU Blue | `#00a3e0` | `$uds-color-base-blue` |
| Focus Blue (a11y) | `#00baff` | `$uds-color-base-bluefocus` |

Maroon and gold are the primary brand colors. Darkgold `#7f6227` and darkmaroon
`#440e22` are visited states.
Expand Down
1 change: 0 additions & 1 deletion packages/unity-bootstrap-theme/src/scss/_custom-asu-variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ $uds-color-base-white: #ffffff; // White
$uds-color-base-green: #78be20; // ASU Green
$uds-color-base-orange: #ff7f32; // ASU Orange
$uds-color-base-blue: #00a3e0; // ASU Blue
$uds-color-base-bluefocus: #00baff; // A11y Focus Blue - used for highlighting the page element with current focus
$uds-color-base-darkgold: #7f6227; // Visited state of ASU Gold
$uds-color-base-darkmaroon: #440e22; // Visited state of ASU Maroon
// Deprecated-start
Expand Down
16 changes: 0 additions & 16 deletions packages/unity-bootstrap-theme/src/scss/extends/_cards.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ Cards - Table of Contents
cursor: $card-basic-hover-cursor;
}

.card-hover:focus {
outline: 0;
box-shadow: 0 0 8px $uds-color-base-bluefocus !important;
}

.card-hover > button {
border: none;
background: transparent;
Expand All @@ -83,12 +78,6 @@ Cards - Table of Contents
padding: 0;
}

.card-hover > button:focus {
outline: 0;
box-shadow: 0 0 8px $uds-color-base-bluefocus !important;
border: 0;
}

.card-icon-top {
width: $card-basic-icon-top-width;
height: $card-basic-icon-top-width;
Expand Down Expand Up @@ -505,11 +494,6 @@ Cards - Table of Contents
color: $uds-color-base-maroon;
}

&:focus-visible {
outline: 2px solid $uds-color-base-bluefocus;
outline-offset: 2px;
}

@include media-breakpoint-down(md) {
color: $uds-color-base-maroon;
border-color: $uds-color-base-maroon;
Expand Down
7 changes: 0 additions & 7 deletions packages/unity-bootstrap-theme/src/scss/variables/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ $blue: $uds-color-base-blue;
$green: $uds-color-base-green;
$orange: $uds-color-base-orange;

$bluefocus: $uds-color-base-bluefocus;
$darkgold: $uds-color-base-darkgold;
$darkmaroon: $uds-color-base-darkmaroon;

Expand All @@ -45,7 +44,6 @@ $colors: map-merge(
'green': $green,
'orange': $orange,
'white': $white,
'bluefocus': $bluefocus,
'darkgold': $darkgold,
'darkmaroon': $darkmaroon,
),
Expand Down Expand Up @@ -96,11 +94,6 @@ $link-hover-color: $maroon;
$link-hover-decoration: none;
$link-visited-color: $uds-color-base-darkmaroon;

:focus {
outline: 0;
box-shadow: 0 0 8px $uds-color-base-bluefocus !important;
}

// Darken percentage for links with `.text-*` class (e.g. `.text-success`)
// $emphasized-link-hover-darken-percentage: 15%;

Expand Down