Repository navigation
Conversation
… the hydrostatic outflow BC With EB, the density handed to set_outflow_bcs holds a sentinel in covered cells (1.2345e20 from level_project, COVERED_VAL from initialPressureProject). computeRhoG integrated it down each column of the outflow strip, so every node below a covered cell got phi ~ 1e20*g*dh: with gravity on and a body in the two-cell strip, dt collapsed to ~1e-22 and the nodal rhs reached ~1e41. set_outflow_bcs_at_level now gathers a copy of the density with covered cells marked negative, and computeRhoG replaces each marked cell with the density of the nearest fluid cell above it in its column (below it, if the top of the column is covered), or the mean fluid density of the strip for a fully covered column, before integrating. Configurations with no covered cells in the strip are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atic outflow BC
With EB, the density handed to set_outflow_bcs holds a sentinel in covered cells (1.2345e20 from level_project, COVERED_VAL from initialPressureProject). computeRhoG integrated it down each column of the outflow strip, so every node below a covered cell got phi ~ 1e20gdh: with gravity on and a body in the two-cell strip, dt collapsed to ~1e-22 and the nodal rhs reached ~1e41.
set_outflow_bcs_at_level now gathers a copy of the density with covered cells marked negative, and computeRhoG replaces each marked cell with the density of the nearest fluid cell above it in its column (below it, if the top of the column is covered), or the mean fluid density of the strip for a fully covered column, before integrating. Configurations with no covered cells in the strip are unchanged.