Repository navigation
Conversation
…B; refine cut cells in shock decks AMReX's MLNodeLaplacian does not support a multilevel nodal solve whose coarse/fine boundary crosses an EB body (AMReX-Codes/amrex#6069); MLMG diverges. Add Projection::checkCoarseFineBoundaryEB, called from doMLMGNodalProjection for composite (nlevel > 1) solves, which aborts with a message pointing at the grids if any cut or covered fine cell touches the coarse/fine boundary. Change regtest.2d.shock_past_cylinder and regtest.3d.shock_past_sphere to refine on cut cells (ns.refine_cutcells = 1) instead of a fixed box that bisected the body, so both decks run again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
WeiqunZhang
approved these changes
Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t cells in shock decks
AMReX's MLNodeLaplacian does not support a multilevel nodal solve whose coarse/fine boundary crosses an EB body (AMReX-Codes/amrex#6069); MLMG diverges. Add Projection::checkCoarseFineBoundaryEB, called from doMLMGNodalProjection for composite (nlevel > 1) solves, which aborts with a message pointing at the grids if any cut or covered fine cell touches the coarse/fine boundary.
Change regtest.2d.shock_past_cylinder and regtest.3d.shock_past_sphere to refine on cut cells (ns.refine_cutcells = 1) instead of a fixed box that bisected the body, so both decks run again.
Closes #267