Repository navigation
Fix issue #239: remove uncalled MacProj and OutFlowBC code - #264
Merged
Merged
Conversation
- Remove the mac_sync_compute overload that takes precomputed edge states for a single scalar. Nothing in Source/, Exec/ or Tutorials/ calls it; the only caller of mac_sync_compute is NavierStokes::mac_sync, which uses the full-state overload. It was also a maintenance trap: unlike the live overload it never adds Ucorr to mac_reg, so a future caller would silently get an inconsistent MAC register. - Remove OutFlowBC::SemiGrow and OutFlowBC::SemiCoarsen, which have no callers; GetOutFlowFaces and HasOutFlowBC are the only members in use. Also drop the stale class comment describing OutFlowBC as the base class of MacOutFlowBC and ProjOutFlowBC, neither of which exists any more. Deletions of uncalled code only. regtest.2d.hotspot (2 levels of refinement, so mac_sync runs) agrees bit-for-bit with the previous code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239.
mac_sync_computeoverload that takes precomputed edge states for a single scalar (MacProj.Hdeclaration + its definition inMacProj.cpp). Nothing inSource/,Exec/orTutorials/calls it — the only call tomac_sync_computeisNavierStokes::mac_sync(NavierStokes.cpp:1514), which binds the full-state overload. It was also a maintenance trap: unlike the live overload it never addsUcorrtomac_reg, so a future caller would silently get an inconsistent MAC register.OutFlowBC::SemiGrowandOutFlowBC::SemiCoarsen, which have no callers;GetOutFlowFacesandHasOutFlowBCare the only members in use. Also dropped the stale class comment describingOutFlowBCas the base class ofMacOutFlowBC/ProjOutFlowBC, neither of which exists any more.Deletions of uncalled code only.
Verification
Exec/run2dandExec/run3dboth build clean.regtest.2d.hotspot(amr.max_level = 2, somac_syncactually runs) agrees bit-for-bit with the pre-change build on all fields at all levels (fcompare: PLOTFILE AGREE).🤖 Generated with Claude Code