Repository navigation
Fix issue #206: don't divide Laplacian_S tracer viscous reflux by rho… - #260
Merged
Merged
Conversation
…eflux by rho_half In reflux, the viscous flux-register correction of every NonConservative scalar was divided by rho_half. That is right only for scalars diffused in the RhoInverse_Laplacian_S form (rho dS/dt = div beta grad S, e.g. Temp). The default tracer is NonConservative but uses Laplacian_S (dS/dt = div beta grad S), and the rest of the sync path treats its Ssync as a rate of S without rho, so its viscous reflux was off by a factor 1/rho_half. Restrict the division to NonConservative scalars with diffusionType RhoInverse_Laplacian_S. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asalmgren
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_half
In reflux, the viscous flux-register correction of every NonConservative scalar was divided by rho_half. That is right only for scalars diffused in the RhoInverse_Laplacian_S form (rho dS/dt = div beta grad S, e.g. Temp). The default tracer is NonConservative but uses Laplacian_S (dS/dt = div beta grad S), and the rest of the sync path treats its Ssync as a rate of S without rho, so its viscous reflux was off by a factor 1/rho_half. Restrict the division to NonConservative scalars with diffusionType RhoInverse_Laplacian_S.