feat(workcell): migrate scheduler config to Pydantic ImportString#346
Open
Btate712 wants to merge 1 commit into
Open
feat(workcell): migrate scheduler config to Pydantic ImportString#346Btate712 wants to merge 1 commit into
Btate712 wants to merge 1 commit into
Conversation
Replace the raw string + importlib.import_module pattern with Pydantic's ImportString type, so import errors are caught at settings parse time (startup) rather than when the engine first initializes. The new preferred format is 'module:ClassName' (e.g. 'madsci.workcell_manager.schedulers.default_scheduler:Scheduler'), which removes the implicit convention that the class must be named Scheduler. Old bare-module strings are still accepted for one release cycle and emit a DeprecationWarning. Closes AD-SDL#340 (scheduler half; event_handlers half blocked on AD-SDL#312) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Btate712
changed the title
Btate712
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Partially closes #340 (scheduler half; the `event_handlers` half is blocked on #312)
Replaces `scheduler: str` + `importlib.import_module()` with Pydantic's `ImportString` type in `WorkcellManagerSettings`, so misconfigured scheduler paths are caught at startup rather than when the engine first initializes.
The new preferred format is `module:ClassName` (e.g. `madsci.workcell_manager.schedulers.default_scheduler:Scheduler`), removing the implicit convention that the scheduler class must be named `Scheduler`. Old bare-module strings are still accepted for one release cycle and emit a `DeprecationWarning`. The now-unnecessary `import importlib` is removed from `workcell_engine.py` and the 3-line scheduler instantiation collapses to a single call.
Developer Checklists
I have: