feat(portal): i18n 接线 2/2 — #269 门户页 (role/community/admin/sale)#308
Merged
Conversation
…in/sale) Wire the four management-portal dashboard pages to useTranslation. locales: +rolePage/communityPage/adminPage/salePage namespaces (594 keys total, en/zh in parity). Verified: type-check 0, i18n:check pass (594 keys), lint clean, next build pass.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
clestons
approved these changes
Jun 14, 2026
clestons
left a comment
clestons
left a comment
There was a problem hiding this comment.
Re-review: feat(portal): i18n 接线 2/2 — #269 门户页 (role/community/admin/sale)
Verdict: APPROVE — 2-round (pure i18n wiring). Content verified identical to the previously APPROVE'd #307; re-approval on the rebased/direct-to-master version.
Spot-checked against #307 findings
Same four portal pages (app/admin, app/community, app/role, app/sale), same useTranslation() + t() pattern, same adminPage.* / communityPage.* / rolePage.* / salePage.* locale key structure. All prior confirmed points hold:
useEffecterror paths uset()as informational ✅common.loadingcross-section key reuse correct ✅- Interpolation variables (
{{chainId}},{{address}},{{count}}, etc.) symmetric EN/ZH ✅ t("salePage.gtokenNotConfigured", { env: "GTOKEN_SALE_ADDRESS" })env var interpolation ✅- Locale additions (+130 keys × 2 sides) parity confirmed by
i18n:checkCI guard ✅
No new findings introduced by the rebase. The useEffect Low suggestion from #307 (add t to dep array) still applies as a non-blocking follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目标
i18n 文案接线 2/2:把 #269 的 4 个门户 dashboard 页接入 i18next。
改动
app/{role,community,admin,sale}/page.tsx→useTranslationrolePage/communityPage/adminPage/salePage(en/zh 各 594 key 完全一致)说明
role.name直出 API 英文值,要中文需 roleId→译名映射(超出本次范围)i18n:check594 key 一致、lint 干净、next build 通过