Skip to content

E as editinacme#703

Open
rakoo wants to merge 7 commits into
9fans:masterfrom
rakoo:E-as-editinacme
Open

E as editinacme#703
rakoo wants to merge 7 commits into
9fans:masterfrom
rakoo:E-as-editinacme

Conversation

@rakoo

@rakoo rakoo commented Mar 5, 2025

Copy link
Copy Markdown

In the expected case where the files ends up being edited in acme, do as editinacme does: when the window of the file is closed it means we're done. No need for an extra binary in another repository. The old logic is kept as a backup.

In addition, allow line numbers to be specified in the input (as in E file:13) and still work with both logics.

@rakoo

rakoo commented Mar 12, 2025

Copy link
Copy Markdown
Author

For reference lazygit merged a change that can use acme as a preset, and I want to be able to use E as my editor in which case the changes there can be used. I don't want to depend on editinacme so that'd be great

@musvaage

Copy link
Copy Markdown

Is your sed command portable?

@rakoo

rakoo commented Mar 27, 2025

Copy link
Copy Markdown
Author

Good call, I'll rework it

@musvaage

musvaage commented Mar 27, 2025

Copy link
Copy Markdown

Please don't consider me a Reviewer.

@rakoo rakoo force-pushed the E-as-editinacme branch 4 times, most recently from 48f44f7 to b764671 Compare April 4, 2025 15:44
@rakoo

rakoo commented Apr 4, 2025

Copy link
Copy Markdown
Author

requires #708

@yrk-lab

yrk-lab commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Albeit similar in function, E and editinacme differ quite a bit in how they operate. Sometimes one can be found usable when the other doesn't work, e.g. as a remote command. I'd advocate to rather keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants