Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS keychain adapter has a couple of drift points that make custom keychains less reliable:
KeychainSynchronizableis exposed inConfigbut was not copied into the adapter, and metadata lookups did not use the configured keychain search list even though reads, writes, deletes, and key listing did.This makes custom-keychain callers more predictable. For example, an item written through
Open(Config{KeychainName: ...})can now have its metadata read from the same keychain, and synchronizable keychain configuration reaches the item setup path.The implementation centralizes the repeated generic-password item and query setup in the macOS adapter, keeps existing legacy keychain behavior intact, and tightens missing-key handling so only known missing item or keychain Security errors map to
ErrKeyNotFound. The macOS tests now go throughOpen(Config)for the config and metadata regressions and clean up temporary keychains reliably.