Audio effect feature built in the video-core player - #914
Open
Mouthieu wants to merge 5 commits into
Open
Conversation
merging audio-effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an audio-effect extension (more of an equalizer) for the video-core player for online streaming.
I made sure to make it easy to configure and added only few changes on existing files.
AI disclosure
I used Gemini to generate a satisfying frontend that would fit the existing UI

Visualization when no sound is playing (basically when the player is paused)
I also used chatGPT for a bunch of other debugging problems that I had (along with Gemini) but I didn't use them for the backend part.
~: Regarding the tests, I honestly did not really understand the whole testing architecture, I was just changing the values of my equalizer and listening to the changes directly.
Just a little disclaimer concerning these lines :
I don't know if you already have existing ways to keep some stuff in memory but that's kind of a trick that I used, tell me if there is something better to implement.
Checklist
CONTRIBUTING.md