修复 dig_quad 相关的状态更新,统一使用 modeData.digQuad 处理得分和额外四分的逻辑 - #1233
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the dig_quad_10l (TECHRASH 10L) mode to move mode-specific progress tracking out of the generic P.stat table and into P.modeData, while also introducing an extraQuad counter to improve rank calculation based on “extra” non-dig quads.
Changes:
- Switched progress tracking/display/scoring from
P.stat.dig_quadtoP.modeData.digQuad. - Added
P.modeData.extraQuad, incremented on 4-line clears that don’t clear any garbage rows, and used it ingetRank. - Reset
digQuadandextraQuadat mode start via the mode’stask.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
dig_quad_10l.luamode logic to use a newmodeDatatable for tracking progress and adds anextraQuadcounter to improve rank calculation. The main changes focus on refactoring how the number of lines dug and extra quads are tracked, and adjusting the scoring and ranking logic accordingly.Refactoring and Data Tracking:
P.stat.dig_quadtoP.modeData.digQuadfor consistency and better separation of mode-specific data. [1] [2]P.modeData.extraQuadto count extra quads cleared under specific conditions, incremented when a quad is cleared on row 4 with no digs.Scoring and Ranking Logic:
scoreandgetRankfunctions to useP.modeData.digQuadandP.modeData.extraQuad, and changed the rank calculation to subtract a value based onextraQuadinstead of the previous method.digQuadandextraQuadto zero at the start of the mode.These changes make the mode's data handling more robust and the ranking system more accurate.