Skip to content

修复 dig_quad 相关的状态更新,统一使用 modeData.digQuad 处理得分和额外四分的逻辑 - #1233

Merged
MrZ626 merged 1 commit into
mainfrom
bugfix/dig_quad_10l
Aug 11, 2026
Merged

修复 dig_quad 相关的状态更新,统一使用 modeData.digQuad 处理得分和额外四分的逻辑#1233
MrZ626 merged 1 commit into
mainfrom
bugfix/dig_quad_10l

Conversation

@ParticleG

Copy link
Copy Markdown
Member

This pull request updates the dig_quad_10l.lua mode logic to use a new modeData table for tracking progress and adds an extraQuad counter to improve rank calculation. The main changes focus on refactoring how the number of lines dug and extra quads are tracked, and adjusting the scoring and ranking logic accordingly.

Refactoring and Data Tracking:

  • Changed all tracking of dug lines from P.stat.dig_quad to P.modeData.digQuad for consistency and better separation of mode-specific data. [1] [2]
  • Introduced P.modeData.extraQuad to count extra quads cleared under specific conditions, incremented when a quad is cleared on row 4 with no digs.

Scoring and Ranking Logic:

  • Updated the score and getRank functions to use P.modeData.digQuad and P.modeData.extraQuad, and changed the rank calculation to subtract a value based on extraQuad instead of the previous method.
  • Reset both digQuad and extraQuad to zero at the start of the mode.

These changes make the mode's data handling more robust and the ranking system more accurate.

Copilot AI lite review requested due to automatic review settings August 11, 2026 17:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the dig_quad_10l (TECHRASH 10L) mode to move mode-specific progress tracking out of the generic P.stat table and into P.modeData, while also introducing an extraQuad counter to improve rank calculation based on “extra” non-dig quads.

Changes:

  • Switched progress tracking/display/scoring from P.stat.dig_quad to P.modeData.digQuad.
  • Added P.modeData.extraQuad, incremented on 4-line clears that don’t clear any garbage rows, and used it in getRank.
  • Reset digQuad and extraQuad at mode start via the mode’s task.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@MrZ626
MrZ626 merged commit f6875ba into main Aug 11, 2026
9 checks passed
@MrZ626
MrZ626 deleted the bugfix/dig_quad_10l branch August 11, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants