Enrich PartnerSuggestion serializer with incident card fields#57
Merged
immerSIR merged 1 commit intoJul 2, 2026
Merged
Conversation
…thumbnail/description/details)
immerSIR
force-pushed
the
fix/suggestion-card-incident-fields
branch
from
6ffc3a7 to
9a8ceba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the frontend Collaborations → Demandes tab, cards sourced from partner suggestions (
/my-suggestions/received/,/my-suggestions/sent/) rendered empty — no photo, no description, no incident details — while cards sourced from collaboration requests (/collaboration/) rendered fully. The two lists are merged in the same tab, so the suggestion cards looked broken.Root cause
PartnerSuggestionSerializerexposed onlyincident_title, whereasCollaborationSerializeralso exposesincident_photo,incident_thumbnail,incident_details, etc. The FE renders both card types with the same component, so suggestion items had nothing to show.Fix
Add to
PartnerSuggestionSerializerthe same incident card fields asCollaborationSerializer(all read-only, additive — no breaking change):incident_photo,incident_thumbnail,incident_description,incident_zone,incident_etat,incident_details.Verified on prod: the incident data + storage files (photo/thumbnail) already resolve (HTTP 200); only the serializer was missing the fields.
Docs updated in
Dashboardv2/BACKEND_API.md(+.fr.md).