Amanda/cratedb#394
Merged
Merged
Conversation
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
…ble within openai shell plugin Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
Signed-off-by: Amanda Crawley <amanda.crawley@agilebits.com>
scottisloud
approved these changes
May 15, 2026
Contributor
scottisloud
left a comment
scottisloud
left a comment
There was a problem hiding this comment.
Approved (LGTM). I pushed a few commits to align the generated CLI flags with the current CrateDB docs (--user → --username, --host → --hosts). Everything else looked good on review.
Thanks for sticking with this PR and for the contribution, @accraw.
JillRegan
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just #313 with the test fixed and commits signed