Skip to content

refactor(frontend): add tested shared overlays and UI primitives - #129

Merged
gac0812 merged 1 commit into
1024XEngineer:MVPfrom
gac0812:codex/frontend-shared-overlays
Aug 1, 2026
Merged

gac0812 merged 1 commit into
1024XEngineer:MVPfrom
gac0812:codex/frontend-shared-overlays

Conversation

@gac0812

@gac0812 gac0812 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a queue-backed AppDialogProvider for consistent in-app notices and confirmations
  • add a stack-based OverlayProvider with Android hardware-back handling
  • add shared back-button and bottom-sheet primitives plus focused theme/date helpers
  • add a Jest and React Native Testing Library harness to the frontend quality gate

Why

The next frontend changes need reusable overlays and app-owned dialogs without duplicating modal state or falling back to platform system alerts. This PR lands that foundation independently and covers its behavior before any schedule, voice, location, alarm, or app-shell integration is introduced.

Impact

Existing screens are not rewired in this PR, so current user-facing flows remain unchanged. Follow-up PRs can adopt these primitives while keeping their feature diffs focused.

Validation

  • npm ci
  • npm run check (6 suites, 22 tests)
  • npx expo export --platform android --output-dir ../../android-export

@gac0812 gac0812 changed the title [codex] refactor(frontend): add tested shared overlays and UI primitives refactor(frontend): add tested shared overlays and UI primitives Jul 31, 2026
@gac0812
gac0812 marked this pull request as ready for review July 31, 2026 10:41

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this review.

Validation completed with npm run check: ESLint, Prettier formatting, TypeScript typecheck, and all 22 tests passed across 6 suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant