fix: add missing break in DAI permit switch in getTypedData_ (BB3402573)#63
Merged
Merged
Conversation
|
py-zoid
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Bug
getTypedData_insrc/lxly/erc20.tscontains aswitch (permitType)statement where thecase Permit.DAI:block was missing abreakstatement. This caused fall-through intocase Permit.EIP_2612:, which overwritestypedData.types.PermitandtypedData.messagewith the EIP-2612 schema after the DAI-specific values had already been set.Impact
Any call path that signs a DAI permit (e.g.
bridgeAssetWithPermitfor DAI tokens) would silently use the EIP-2612 typed data schema instead of the DAI schema. The resulting signature would be invalid against DAI's on-chainpermit()implementation, causing the transaction to revert. DAI permits have been effectively broken since this code path was introduced.Fix
Added a single
break;after the closing brace of thetypedData.messageassignment incase Permit.DAI:, beforecase Permit.EIP_2612:. This ensures DAI permit typed data is returned as-is without overwriting.Fixes BB3402573.