Repository navigation
fix(useHead): avoid undefined document.title without a title - #122
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
useHead always queued its title, even when none was passed, and the dispatcher rendered that undefined queue entry as the literal string "undefined". A metas-only useHead could therefore replace the document title, including a title managed by useTitle in a parent component. Only queue a title from useHead when one is provided, and only assign document.title while a title or template is queued. Add regression tests for metas-only useHead and useMeta.
🦋 Changeset detectedLatest commit: 8b14226 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useHeadqueued itstitleon mount even when no title was provided, and the dispatcher always wrote the first queued title todocument.title. A metas-onlyuseHeadtherefore setdocument.titleto the literal string"undefined", and a metas-only child could overwrite a title set byuseTitlein a parent.useHeadwhen one is provided.document.titlewhile a title or template is queued, so a metas-only render leaves an existing/static title alone.Reproduction
Before this change
document.titlebecame"undefined"after the first batch; with the change it stays"Parent title".Validation
useHeadregression tests for a metas-only render and a metas-only child underuseTitle.useMeta-only regression test for the dispatcher title handling.pnpm test -- --run: 39 tests passed.pnpm build: passed.The changeset is a patch for
hoofd.