fix(ci): build the dump path by joining, and publish around a failed kernel

The autovec tests pasted a forward slash onto the result of
`canonicalize`, which on Windows is a verbatim `\\?\C:\...` path. A
verbatim path takes no forward slash as a separator, so the name was
rejected outright and all three tests failed on the msvc target. They
never ran before now: the target failed to build, so this surfaced only
once that was fixed.

A failed kernel also took the whole site down with it. `benchmark-
aggregate` depended on `benchmark` without `always()`, so any matrix leg
failing skipped aggregation, which skipped the deploy. One crashing
kernel therefore blanked every other kernel's published numbers rather
than just its own row. Aggregation now runs on whatever legs produced
results, and still fails loudly if no x86_64 partial exists at all.

Author: darmie

.github/workflows/wiki.yml

@@ -195,6 +195,12 @@ jobs:
   benchmark-aggregate:
     name: Aggregate benchmark results
     needs: benchmark
+    # `needs` alone would skip this whenever any matrix leg failed, and a
+    # skipped aggregate skips the deploy, so one crashing kernel takes the
+    # whole published page down with it rather than just its own row. Run
+    # on the legs that did produce results; a kernel that failed simply has
+    # no partial to merge and does not appear.
+    if: ${{ always() && needs.benchmark.result != 'cancelled' }}
     runs-on: ubuntu-latest
     steps:
       - name: Download x86_64 per-kernel results
@@ -224,10 +230,15 @@ jobs:
         # report both. The page loads each file and labels the switch
         # from its own `meta.cpu`.
         run: |
-          ls -la bench-parts/
           mkdir -p bench-out
-          jq -s 'reduce .[] as $x ({}; . * $x)' bench-parts/*.json > bench-out/results.json
-          cat bench-out/results.json | jq 'keys'
+          ls -la bench-parts/ || true
+          if compgen -G 'bench-parts/*.json' > /dev/null; then
+            jq -s 'reduce .[] as $x ({}; . * $x)' bench-parts/*.json > bench-out/results.json
+            cat bench-out/results.json | jq 'keys'
+          else
+            echo "::error::no x86_64 partials produced; nothing to publish"
+            exit 1
+          fi
           # macOS runners are best-effort: a failed or skipped leg leaves
           # no partials, and the page renders the x86_64 set alone.
           if compgen -G 'bench-parts-macos/*.json' > /dev/null; then
@@ -246,6 +257,7 @@ jobs:
 
   deploy-site:
     needs: benchmark-aggregate
+    if: ${{ always() && needs.benchmark-aggregate.result == 'success' }}
     runs-on: ubuntu-latest
     environment:
       name: github-pages

crates/zynml/tests/autovec.rs

@@ -18,14 +18,15 @@ static DUMPING: Mutex<()> = Mutex::new(());
 
 fn build(src: &str, dump: &str) -> (f64, usize) {
     let _serialised = DUMPING.lock().unwrap_or_else(|e| e.into_inner());
-    let dir = format!(
-        "{}/target/hirdump_{dump}",
-        Path::new(env!("CARGO_MANIFEST_DIR"))
-            .join("../..")
-            .canonicalize()
-            .unwrap()
-            .display()
-    );
+    // Built by joining rather than formatting: `canonicalize` returns a
+    // verbatim `\\?\C:\...` path on Windows, which takes no forward
+    // slash as a separator, so pasting one in makes the name invalid.
+    let dir = Path::new(env!("CARGO_MANIFEST_DIR"))
+        .join("../..")
+        .canonicalize()
+        .unwrap()
+        .join("target")
+        .join(format!("hirdump_{dump}"));
     std::fs::remove_dir_all(&dir).ok();
     std::fs::create_dir_all(&dir).unwrap();
     // Process-global, and these tests share a process, so each one
@@ -53,7 +54,8 @@ fn build(src: &str, dump: &str) -> (f64, usize) {
         .collect();
     assert!(
         !hir.is_empty(),
-        "no HIR dump at {dir}; the vector-op count below would be meaningless"
+        "no HIR dump at {}; the vector-op count below would be meaningless",
+        dir.display()
     );
     let vector_ops = hir.matches("vload").count() + hir.matches("vstore").count();
     (value, vector_ops)