From 7932d12d0fe78c0fd3b64fa5c71f5707c1f4e8e4 Mon Sep 17 00:00:00 2001
From: Mikhail Kot <to@myrrc.dev>
Date: Fri, 10 Apr 2026 17:16:24 +0100
Subject: [PATCH] allow , in glob expression

Signed-off-by: Mikhail Kot <to@myrrc.dev>
---
 vortex-io/src/filesystem/glob.rs | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/vortex-io/src/filesystem/glob.rs b/vortex-io/src/filesystem/glob.rs
index adb6da3c394..e1fb3873601 100644
--- a/vortex-io/src/filesystem/glob.rs
+++ b/vortex-io/src/filesystem/glob.rs
@@ -18,19 +18,39 @@ impl dyn FileSystem + '_ {
     /// to narrow the [`list`](FileSystem::list) call. The full glob pattern is
     /// then applied as a filter over the listed entries.
     ///
-    /// Escaped glob characters (`\*`, `\?`, `\[`) are not supported.
+    /// Escaped glob characters (`\*`, `\?`, `\[`, `\,`) are not supported.
+    ///
+    /// If "," is encountered, splits paths by it. Using comma in conjunction with
+    /// glob characters is not supported.
     pub fn glob(&self, pattern: &str) -> VortexResult<BoxStream<'_, VortexResult<FileListing>>> {
         validate_glob(pattern)?;
 
-        // If there are no glob characters, the pattern is an exact file path.
+        // If there are no glob characters and no comma, the pattern is an exact file path.
         // Return it directly without listing the filesystem.
-        if !pattern.contains(['*', '?', '[']) {
+        let has_expansion = pattern.contains(['*', '?', '[']);
+        let has_comma = pattern.contains(',');
+        if !has_expansion && !has_comma {
             let listing = FileListing {
                 path: pattern.to_string(),
                 size: None,
             };
             return Ok(futures::stream::once(async { Ok(listing) }).boxed());
         }
+        if has_comma && has_expansion {
+            vortex_bail!("Comma with glob expressions is not supported");
+        }
+        if has_comma {
+            let paths: Vec<_> = pattern
+                .split(',')
+                .map(|path| {
+                    Ok(FileListing {
+                        path: path.to_owned(),
+                        size: None,
+                    })
+                })
+                .collect();
+            return Ok(futures::stream::iter(paths).boxed());
+        }
 
         let glob_pattern = glob::Pattern::new(pattern)
             .map_err(|e| vortex_err!("Invalid glob pattern '{}': {}", pattern, e))?;
@@ -69,7 +89,7 @@ fn glob_list_prefix(pattern: &str) -> &str {
 
 /// Validates that a glob pattern does not contain escaped glob characters.
 fn validate_glob(pattern: &str) -> VortexResult<()> {
-    for escape_pattern in ["\\*", "\\?", "\\["] {
+    for escape_pattern in ["\\*", "\\?", "\\[", "\\,"] {
         if pattern.contains(escape_pattern) {
             vortex_bail!(
                 "Escaped glob characters are not allowed in patterns. Found '{}' in: {}",