Skip to content

Commit fde4b39

Browse files
committed
Use the blanket RowFn vtable in benchmarks
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent b184ca9 commit fde4b39

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

‎vortex-array/benches/row_fn_executor.rs‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ use vortex_array::scalar_fn::OutputSink;
2424
use vortex_array::scalar_fn::RowFn;
2525
use vortex_array::scalar_fn::RowVisitor;
2626
use vortex_array::scalar_fn::ScalarFnId;
27-
use vortex_array::scalar_fn::ScalarFnVTable;
2827
use vortex_array::validity::Validity;
2928
use vortex_buffer::Buffer;
3029
use vortex_buffer::BufferMut;
@@ -168,10 +167,6 @@ impl RowFn for RowSinkWrappingAdd {
168167
}
169168
}
170169

171-
vortex_array::impl_row_fn_vtable!(RowWrappingAdd);
172-
vortex_array::impl_row_fn_vtable!(RowCheckedAdd);
173-
vortex_array::impl_row_fn_vtable!(RowSinkWrappingAdd);
174-
175170
fn inputs() -> (ArrayRef, ArrayRef) {
176171
let lhs = (0..ROWS)
177172
.map(|index| index as i64)
@@ -208,7 +203,7 @@ fn nullable_inputs() -> (ArrayRef, ArrayRef) {
208203

209204
fn bench_row_fn<F>(bencher: Bencher, function: F, make_inputs: fn() -> (ArrayRef, ArrayRef))
210205
where
211-
F: RowFn<Options = EmptyOptions> + ScalarFnVTable<Options = EmptyOptions>,
206+
F: RowFn<Options = EmptyOptions>,
212207
{
213208
bencher
214209
.with_inputs(make_inputs)

‎vortex-array/benches/strict_validity.rs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ impl RowFn for LazyDouble {
106106
}
107107
}
108108

109-
vortex_array::impl_row_fn_vtable!(LazyDouble);
110-
111109
/// The same function, applying validity the way the adapter used to: materialize a mask first.
112110
#[derive(Clone)]
113111
struct EagerDouble;

0 commit comments

Comments
 (0)