chore: deny clippy::inline_always at the workspace level (#9726)

Co-authored-by: Claude <noreply@anthropic.com>

Author: joseph-isaacs

Cargo.toml

@@ -380,6 +380,7 @@ get_unwrap = "deny"
 host_endian_bytes = "deny"
 if_then_some_else_none = "deny"
 inconsistent_struct_constructor = "deny"
+inline_always = "deny"
 manual_assert = "deny"
 manual_is_variant_and = "deny"
 many_single_char_names = "deny"

encodings/fastlanes/src/bitpacking/array/unpack_iter.rs

@@ -33,6 +33,7 @@ pub trait UnpackStrategy<T: PhysicalPType> {
 pub struct BitPackingStrategy;
 
 impl<T: PhysicalPType<Physical: BitPacking>> UnpackStrategy<T> for BitPackingStrategy {
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     unsafe fn unpack_chunk(
         &self,
@@ -153,6 +154,7 @@ impl<'a, T: PhysicalPType, S: UnpackStrategy<T>> UnpackedChunks<'a, T, S> {
         })
     }
 
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     const fn elems_per_chunk(&self) -> usize {
         128 * self.bit_width / size_of::<T>()

encodings/fastlanes/src/for/array/for_decompress.rs

@@ -35,6 +35,7 @@ struct FoRStrategy<T> {
 }
 
 impl<T: PhysicalPType<Physical = T> + FoR> UnpackStrategy<T> for FoRStrategy<T> {
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     unsafe fn unpack_chunk(
         &self,

encodings/runend/src/decompress_bool.rs

@@ -101,6 +101,7 @@ pub fn runend_decode_typed_bool(
 /// Fast path for few runs with no offset. Uses direct slice access to minimize overhead.
 /// This avoids the `trimmed_ends_iter` iterator chain which adds significant overhead
 /// for small numbers of runs.
+#[allow(clippy::inline_always)]
 #[inline(always)]
 fn decode_few_runs_no_offset<E: vortex_array::dtype::IntegerPType>(
     ends: &[E],
@@ -220,6 +221,7 @@ fn decode_bool_nullable(
 }
 
 /// Sequential decode for few runs - avoids prefill overhead.
+#[allow(clippy::inline_always)]
 #[inline(always)]
 fn decode_nullable_sequential(
     run_ends: impl Iterator<Item = usize>,

vortex-array/src/aggregate_fn/fns/sum/mod.rs

@@ -370,6 +370,7 @@ pub(crate) fn make_zero_state(return_dtype: &DType) -> SumState {
 }
 
 /// Checked add for u64, returning true if overflow occurred.
+#[allow(clippy::inline_always)]
 #[inline(always)]
 fn checked_add_u64(acc: &mut u64, val: u64) -> bool {
     match acc.checked_add(val) {
@@ -382,6 +383,7 @@ fn checked_add_u64(acc: &mut u64, val: u64) -> bool {
 }
 
 /// Checked add for i64, returning true if overflow occurred.
+#[allow(clippy::inline_always)]
 #[inline(always)]
 fn checked_add_i64(acc: &mut i64, val: i64) -> bool {
     match acc.checked_add(val) {

vortex-array/src/aggregate_fn/typed.rs

@@ -63,11 +63,13 @@ pub(super) struct AggregateFnInner<V: AggregateFnVTable> {
 }
 
 impl<V: AggregateFnVTable> DynAggregateFn for AggregateFnInner<V> {
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     fn as_any(&self) -> &dyn Any {
         self
     }
 
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     fn id(&self) -> AggregateFnId {
         V::id(&self.vtable)

vortex-array/src/array/erased.rs

@@ -84,12 +84,14 @@ impl ArrayRef {
     }
 
     /// Returns a reference to the `dyn DynArrayData` inside the inner.
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     pub(crate) fn dyn_array(&self) -> &dyn DynArrayData {
         &self.0.data
     }
 
     /// Returns a mutable reference to the inner if this is the sole owner.
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     pub(crate) fn inner_mut(&mut self) -> Option<&mut ArrayInner<dyn DynArrayData>> {
         Arc::get_mut(&mut self.0)
@@ -119,6 +121,7 @@ impl ArrayRef {
     ///
     /// # Safety
     /// The caller must guarantee the concrete type behind `dyn DynArrayData` is `ArrayData<V>`.
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     pub(crate) unsafe fn downcast_inner_unchecked<V: VTable>(
         self,
@@ -791,6 +794,7 @@ impl ArrayRef {
 }
 
 impl IntoArray for ArrayRef {
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     fn into_array(self) -> ArrayRef {
         self

vortex-array/src/array/typed.rs

@@ -348,6 +348,7 @@ impl<V: VTable> Array<V> {
     }
 
     /// Returns the internal [`ArrayRef`].
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     pub fn as_array(&self) -> &ArrayRef {
         &self.inner
@@ -361,6 +362,7 @@ impl<V: VTable> Array<V> {
     }
 
     /// Downcast the inner `ArrayRef` to `&ArrayData<V>`.
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     fn downcast_inner(&self) -> &ArrayData<V> {
         let any = self.inner.dyn_array().as_any();
@@ -508,6 +510,7 @@ impl<V: VTable> AsRef<ArrayRef> for Array<V> {
 }
 
 impl<V: VTable> IntoArray for Array<V> {
+    #[allow(clippy::inline_always)]
     #[inline(always)]
     fn into_array(self) -> ArrayRef {
         self.inner

vortex-array/src/arrays/bool/compute/filter.rs

@@ -129,6 +129,7 @@ fn filter_pext_fallback(src: &BitBuffer, mask_buf: &BitBuffer, true_count: usize
 /// Extracted so the same logic is shared between the software and hardware paths.
 /// Uses raw pointer writes instead of Vec::push to eliminate bounds checks
 /// in the hot loop — we know the exact output size from true_count.
+#[allow(clippy::inline_always)]
 #[inline(always)]
 #[allow(clippy::cast_possible_truncation)]
 fn filter_inner(
@@ -227,6 +228,7 @@ fn filter_inner(
 /// lookup table per mask byte. Each byte PEXT is a single table lookup with no
 /// data dependencies between bytes, making this faster than the parallel-prefix
 /// approach (~12ns vs ~18ns per word).
+#[allow(clippy::inline_always)]
 #[inline(always)]
 pub fn pext_fallback(src: u64, mask: u64) -> u64 {
     pext_byte_lut(src, mask)
@@ -268,6 +270,7 @@ static BYTE_PEXT_LUT: &[u8; 256 * 256] = &{
 };
 
 /// Byte-level PEXT using precomputed lookup table.
+#[allow(clippy::inline_always)]
 #[inline(always)]
 fn pext_byte_lut(src: u64, mask: u64) -> u64 {
     let src_bytes = src.to_le_bytes();

vortex-array/src/arrays/filter/execute/simd_compress/mod.rs

@@ -152,6 +152,7 @@ const fn compress_lut<const ROWS: usize, const BYTES: usize>(
 /// The pointer contract of [`filter_slice_by_bitmap`] / [`filter_slice_mut_by_bitmap`] must hold,
 /// and `bits` must only select elements that are in bounds.
 #[cfg(all(any(target_arch = "x86_64", target_arch = "aarch64"), not(miri)))]
+#[allow(clippy::inline_always)]
 #[inline(always)]
 unsafe fn compress_tail<const IN_PLACE: bool>(
     src: *const u8,
@@ -180,6 +181,7 @@ unsafe fn compress_tail<const IN_PLACE: bool>(
 /// must not overlap `src` and must have room at `write_pos`; in-place, forward compaction must
 /// guarantee `write_pos <= word_start`.
 #[cfg(all(any(target_arch = "x86_64", target_arch = "aarch64"), not(miri)))]
+#[allow(clippy::inline_always)]
 #[inline(always)]
 unsafe fn bulk_copy<const IN_PLACE: bool>(
     src: *const u8,