Skip to content

Commit ec0a8a9

Browse files
committed
Use validity helper in mask reduction
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
1 parent 0c55830 commit ec0a8a9

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

‎vortex-array/src/scalar_fn/fns/mask/kernel.rs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ use crate::arrays::scalar_fn::ScalarFnArrayView;
1717
use crate::kernel::ExecuteParentKernel;
1818
use crate::optimizer::rules::ArrayParentReduceRule;
1919
use crate::scalar_fn::fns::mask::Mask as MaskExpr;
20-
use crate::validity::Validity;
2120

2221
/// Mask an array without reading buffers.
2322
///
@@ -86,11 +85,8 @@ where
8685
.ok_or_else(|| vortex_err!("Mask expression must have 2 children"))?;
8786

8887
if mask_child.as_opt::<Bool>().is_none() && mask_child.as_opt::<Constant>().is_none() {
89-
let can_attach_mask = V::VALIDITY_IS_METADATA_ONLY
90-
&& matches!(
91-
array.validity()?,
92-
Validity::AllValid | Validity::NonNullable
93-
);
88+
let can_attach_mask =
89+
V::VALIDITY_IS_METADATA_ONLY && array.validity()?.definitely_no_nulls();
9490

9591
if !can_attach_mask {
9692
return Ok(None);

0 commit comments

Comments
 (0)