perf(array): reuse canonical decimal operands directly

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>

Author: connortsui20

vortex-array/src/scalar_fn/fns/binary/numeric/decimal.rs

@@ -38,11 +38,13 @@ use vortex_mask::Mask;
 
 use super::checked::checked_lanes;
 use crate::ArrayRef;
+use crate::Canonical;
 use crate::Columnar;
 use crate::ExecutionCtx;
 use crate::IntoArray;
 use crate::arrays::Constant;
 use crate::arrays::ConstantArray;
+use crate::arrays::Decimal;
 use crate::arrays::DecimalArray;
 use crate::arrays::decimal::widened_buffer;
 use crate::dtype::BigCast;
@@ -145,7 +147,10 @@ enum DecimalOperand {
 
 impl DecimalOperand {
     fn try_new(array: &ArrayRef, ctx: &mut ExecutionCtx) -> VortexResult<Option<Self>> {
-        let columnar = array.clone().execute::<Columnar>(ctx)?;
+        let columnar = match array.as_opt::<Decimal>() {
+            Some(array) => Columnar::Canonical(Canonical::Decimal(array.into_owned())),
+            None => array.clone().execute::<Columnar>(ctx)?,
+        };
 
         match columnar {
             Columnar::Constant(array) => match array.scalar().as_decimal().decimal_value() {

vortex-array/src/scalar_fn/fns/binary/numeric/tests.rs

@@ -15,6 +15,7 @@ use crate::VortexSessionExecute;
 use crate::array_session;
 use crate::arrays::ConstantArray;
 use crate::arrays::DecimalArray;
+use crate::arrays::DictArray;
 use crate::arrays::PrimitiveArray;
 use crate::assert_arrays_eq;
 use crate::builtins::ArrayBuiltins;
@@ -420,6 +421,30 @@ fn test_decimal_mixed_storage_widths() -> VortexResult<()> {
     Ok(())
 }
 
+#[test]
+fn test_decimal_encoded_integer_child() -> VortexResult<()> {
+    let mut ctx = array_session().create_execution_ctx();
+    let dtype = DecimalDType::new(10, 2);
+    let values = DictArray::try_new(
+        buffer![0u8, 1, 0].into_array(),
+        PrimitiveArray::from_option_iter([Some(900i32), None]).into_array(),
+    )?
+    .into_array();
+    let lhs = DecimalArray::from_integer_values(values, dtype)?.into_array();
+    let rhs = DecimalArray::from_iter::<i64, _>([150, 225, 150], dtype).into_array();
+
+    let result = decimal_binary(lhs, rhs, Operator::Mul)?;
+    assert_arrays_eq!(
+        result,
+        DecimalArray::from_option_iter::<i128, _>(
+            [Some(135_000), None, Some(135_000)],
+            result_decimal_dtype(dtype, NumericOperator::Mul)?,
+        ),
+        &mut ctx
+    );
+    Ok(())
+}
+
 #[test]
 fn test_decimal_nullable_lanes() -> VortexResult<()> {
     let mut ctx = array_session().create_execution_ctx();