Repository navigation
Commit c93ffa3
authored
fix(python): translate Polars decimal literals (#10187)
Polars decimal comparisons fail because `Scalar.Decimal` is
unrecognized. Preserve the serialized unscaled integer, precision, and
scale in a native Vortex decimal literal, without floating-point
conversion.
This is a direct expression translation; it performs no eager evaluation
and does not require literal arguments. Literal-specific PRs decode the
scalar representation itself.
Validation: 1 targeted regression case(s) passed with this PR’s
converter. With only `polars_.py` restored to the base revision and the
same tests retained, all 1 failed with Polars `ComputeError` wrapping
the unsupported-expression `ValueError` or `NotImplementedError`. The
tests compare complete dataframes from Polars alone and a Vortex-backed
Polars scan, and check explicit row expectations. No lint or broader
suite was run.
Signed-off-by: Daniel King <dan@spiraldb.com>1 parent c00e06c commit c93ffa3
2 files changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
104 | 107 | | |
105 | 108 | | |
106 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
0 commit comments