Skip to content

Commit c128e99

Browse files
ci(bench): run TPC-DS SF=10 and SF=100 nightly on NVMe and S3 (#10508)
## Summary TPC-DS only ran at SF=1 (NVMe). At ~1 GB the data is cache-resident and joins are small, so it says little about scan, pruning, spill or memory behaviour at realistic sizes, and TPC-DS's 99 queries cover far more of that than TPC-H's 22. SF=100 is too slow for PR or per-merge runs, so this adds SF=10 and SF=100 to the nightly preset, next to the existing TPC-H SF=100 runs.
1 parent 5c881c5 commit c128e99

2 files changed

Lines changed: 46 additions & 2 deletions

File tree

‎bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py‎

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"pr-compact": "Pull-request SQL benchmarks for Vortex Compact plus Parquet controls.",
2121
"pr-all": "The union of the pr, pr-compact and pr-full matrices (action/bench-all).",
2222
"pr-full": "Every regular SQL benchmark at full PR target coverage (action/bench-sql-extended).",
23-
"nightly": "Large-scale SF=100 TPC-H on NVMe and S3 at default targets.",
23+
"nightly": "Large-scale SF=100 TPC-H on NVMe and S3, and SF=10/100 TPC-DS on NVMe and S3, at default targets.",
2424
}
2525

2626
# Reusable target coverage
@@ -186,6 +186,43 @@
186186
"develop": STANDARD_WITH_DUCKDB,
187187
},
188188
),
189+
BenchmarkCase(
190+
id="tpcds-nvme-10",
191+
benchmark=Benchmark.TPCDS,
192+
name="TPC-DS SF=10 on NVME",
193+
scale_factor=10.0,
194+
runs={"nightly": DEFAULT},
195+
),
196+
BenchmarkCase(
197+
id="tpcds-nvme-100",
198+
benchmark=Benchmark.TPCDS,
199+
name="TPC-DS SF=100 on NVME",
200+
scale_factor=100.0,
201+
# 99 queries across four targets: fewer passes keep the job inside its timeout.
202+
iterations=3,
203+
runs={"nightly": DEFAULT},
204+
),
205+
BenchmarkCase(
206+
id="tpcds-s3-10",
207+
benchmark=Benchmark.TPCDS,
208+
name="TPC-DS SF=10 on S3",
209+
storage=Storage.S3,
210+
scale_factor=10.0,
211+
local_dir="vortex-bench/data/tpcds/10.0",
212+
remote_key="tpcds/10.0",
213+
runs={"nightly": DEFAULT},
214+
),
215+
BenchmarkCase(
216+
id="tpcds-s3-100",
217+
benchmark=Benchmark.TPCDS,
218+
name="TPC-DS SF=100 on S3",
219+
storage=Storage.S3,
220+
scale_factor=100.0,
221+
iterations=3,
222+
local_dir="vortex-bench/data/tpcds/100.0",
223+
remote_key="tpcds/100.0",
224+
runs={"nightly": DEFAULT},
225+
),
189226
BenchmarkCase(
190227
id="statpopgen",
191228
benchmark=Benchmark.STATPOPGEN,

‎bench-orchestrator/tests/test_matrix.py‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,14 @@
5555
"pr-compact": COMPACT_IDS,
5656
"pr-all": PR_FULL_IDS,
5757
"pr-full": PR_FULL_IDS,
58-
"nightly": ("tpch-nvme", "tpch-s3"),
58+
"nightly": (
59+
"tpch-nvme",
60+
"tpch-s3",
61+
"tpcds-nvme-10",
62+
"tpcds-nvme-100",
63+
"tpcds-s3-10",
64+
"tpcds-s3-100",
65+
),
5966
}
6067

6168

0 commit comments

Comments
 (0)