fixes

Signed-off-by: Robert Kruszewski <github@robertk.io>

Author: robert3005

vortex-array/src/test_harness/trace/tests.rs

@@ -398,7 +398,7 @@ fn trace_optimize_contiguous_filter() -> VortexResult<()> {
     )?
     .into_array();
     let outer =
-        FilterArray::try_new(inner, Mask::from_iter([true, false, true, false]))?.into_array();
+        FilterArray::try_new(inner, Mask::from_iter([false, true, true, false]))?.into_array();
 
     let traced = trace_op_with(
         TraceOptions {
@@ -411,7 +411,7 @@ fn trace_optimize_contiguous_filter() -> VortexResult<()> {
     assert!(optimized_slice.child().is::<Filter>());
     assert_arrays_eq!(
         traced.output,
-        PrimitiveArray::from_iter([0i32, 3]),
+        PrimitiveArray::from_iter([2i32, 3]),
         &mut execution_ctx()
     );
     insta::assert_snapshot!(traced.trace.to_string(), @r"
@@ -435,20 +435,25 @@ fn trace_optimize_contiguous_filter() -> VortexResult<()> {
     // The trace below only records the shape of the execution; pin the values it produced too.
     assert_arrays_eq!(
         traced.output,
-        PrimitiveArray::from_iter([0i32, 3]),
+        PrimitiveArray::from_iter([2i32, 3]),
         &mut execution_ctx()
     );
     insta::assert_snapshot!(traced.trace.to_string(), @"
     execute_until target=AnyCanonical root=vortex.filter(i32, len=2)
       iter 0 current=vortex.filter(i32, len=2) builder_active=false
-        ExecuteSlot slot=0 parent=vortex.filter(i32, len=2) child=vortex.filter(i32, len=4)
-      iter 1 current=vortex.filter(i32, len=4) stack_parent=vortex.filter(i32, len=2) slot=0 builder_active=false
+        Done array=vortex.slice(i32, len=2)
+      iter 1 current=vortex.slice(i32, len=2) builder_active=false
+        ExecuteSlot slot=0 parent=vortex.slice(i32, len=2) child=vortex.filter(i32, len=4)
+      iter 2 current=vortex.filter(i32, len=4) stack_parent=vortex.slice(i32, len=2) slot=0 builder_active=false
         Done array=vortex.primitive(i32, len=4)
-      iter 2 current=vortex.primitive(i32, len=4) stack_parent=vortex.filter(i32, len=2) slot=0 builder_active=false
-        pop_frame slot=0 output=vortex.filter(i32, len=2)
-      iter 3 current=vortex.filter(i32, len=2) builder_active=false
+      iter 3 current=vortex.primitive(i32, len=4) stack_parent=vortex.slice(i32, len=2) slot=0 builder_active=false
+        pop_frame slot=0 output=vortex.slice(i32, len=2)
+      iter 4 current=vortex.slice(i32, len=2) builder_active=false
+    optimize root=vortex.slice(i32, len=2) session=false
+      reduce_parent static:SliceReduceAdaptor(Primitive) slot=0 parent=vortex.slice(i32, len=2) child=vortex.primitive(i32, len=4) -> vortex.primitive(i32, len=2)
+      done output=vortex.primitive(i32, len=2)
         Done array=vortex.primitive(i32, len=2)
-      iter 4 current=vortex.primitive(i32, len=2) builder_active=false
+      iter 5 current=vortex.primitive(i32, len=2) builder_active=false
       return output=vortex.primitive(i32, len=2)
     ");