Repository navigation
Commit 7507307
committed
Reuse validated chunk boundaries during lowering
Copy the already validated chunk start offsets into the existing Concat
Arc instead of repeatedly asking the layout for each child's row count.
Keep V1's offset storage and the base planner/scheduler unchanged. This is
a measured deviation from PR #10540, isolated for comparison with 5231b70.
Four regression cases cover regular, empty, absent, and zero-row chunks;
three fail before the change. No child layouts are materialized to lower
the boundaries. Production change is +7/-10 lines in two files.
Local four-round, five-second standard comparisons show clustered feature
vectors improving 8.0% cached / 3.5% reopen on one core and 17.1% / 4.9%
on 30 cores. The initial taxi cached +6.4% reduced to +0.8% in the longer
run. Nested-struct reopen is still +4.9%; identical-binary controls vary
up to 7.8%, so that result is unresolved rather than dismissed as noise.
Sixteen full-Arrow list cases initially show at most +2.01% slowdown;
longer list confirmation and isolated parent CI remain pending. Repeated
memory checks show no increase in taxi maximum live allocation, and median
requested read counts/bytes are unchanged. No all-cases V1 win is claimed.
Validation: 618 layout tests, all-target/all-feature layout Clippy with
-D warnings, pinned formatting, whitespace, release benchmark builds,
and 72 real-file V1 full-scan-plus-take correctness comparisons passed.
No workspace-wide checks or doctests were run. Keep separate from the
draft PR until the exact-parent CI comparison is assessed.
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>1 parent 5231b70 commit 7507307
3 files changed
Lines changed: 65 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
128 | 133 | | |
129 | 134 | | |
130 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 86 | | |
95 | | - | |
| 87 | + | |
96 | 88 | | |
97 | 89 | | |
98 | 90 | | |
99 | 91 | | |
100 | | - | |
| 92 | + | |
101 | 93 | | |
102 | 94 | | |
103 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| 49 | + | |
46 | 50 | | |
47 | 51 | | |
48 | 52 | | |
| |||
150 | 154 | | |
151 | 155 | | |
152 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
153 | 211 | | |
154 | 212 | | |
155 | 213 | | |
| |||
0 commit comments