Skip to content

Commit 0b9d824

Browse files
committed
Run bench-taskset.sh through bash in bench-compare
The script is not executable in git, so executing it directly fails with EACCES. Also show the benchmarked branch in the run name on push. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeniBAQefdj1j3odtudVTU Signed-off-by: Claude <noreply@anthropic.com>
1 parent a87e4da commit 0b9d824

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/workflows/bench-compare.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
name: Benchmark Compare
1010
run-name: >-
11-
Bench compare ${{ inputs.head_ref || github.ref_name }} vs ${{ inputs.base_ref || 'develop' }}:
11+
Bench compare ${{ inputs.head_ref || (github.event_name == 'push' && 'ji/duckdb-v2-scan-driver') || github.ref_name }} vs ${{ inputs.base_ref || 'develop' }}:
1212
${{ inputs.benchmarks || 'test defaults' }}
1313
1414
concurrency:

‎scripts/bench-compare.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def run_one(exe: Path, filter: str | None, extra: list[str], pin: bool) -> dict[
150150
if filter:
151151
cmd.append(filter)
152152
if pin:
153-
cmd = [str(SCRIPT_DIR / "bench-taskset.sh"), *cmd]
153+
cmd = ["bash", str(SCRIPT_DIR / "bench-taskset.sh"), *cmd]
154154
print("+", " ".join(cmd), file=sys.stderr, flush=True)
155155
proc = subprocess.run(cmd, stdout=subprocess.PIPE, text=True, env={**os.environ, "RUST_BACKTRACE": "1"})
156156
sys.stderr.write(proc.stdout)

0 commit comments

Comments
 (0)