Skip to content

PyPump.request() should be able to get any type of content #132

Description

@kabniel

Current version of PyPump.request() returns response.json(), which means it can only be used for requests where the server will return json data.

We should rewrite it so that it can return all types of content (the full response object?), and let the caller of PyPump.request() decide what to do with it.

This would f.ex let us download media files from https://example.com/uploads/ with pump.request(imgobject.original.url) instead of having to do something weird like requests.get(imgobject.original.url, auth=pump.setup_oauth_client())

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions