From 1421051470656a7d975a47ef4c28acf34c19fde6 Mon Sep 17 00:00:00 2001 From: shujaat hasan Date: Fri, 26 Jun 2026 14:41:15 +0200 Subject: [PATCH] fix: surface model-zoo clone failures and trigger WIP check on reopen Bugbot (promotion PR #21), two findings: - Clone failure misreported as success: the model-zoo clone cell discarded stderr and ran an "already cloned" echo on ANY non-zero exit, so network/ permission/partial-clone failures looked like success. Guard on the directory actually existing; otherwise run git clone and let real errors surface. (notebooks/traceblocTrainingGuide.ipynb:107) - WIP check skips reopened PRs: wip-limit-check.yml listened only for opened/ ready_for_review, so reopened PRs re-entered active work without a WIP check, unlike the sibling kanban/status workflows. Add reopened. (.github/workflows/wip-limit-check.yml:5) Co-Authored-By: Claude Opus 4.8 --- .github/workflows/wip-limit-check.yml | 2 +- notebooks/traceblocTrainingGuide.ipynb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/wip-limit-check.yml b/.github/workflows/wip-limit-check.yml index 8c027df..55bbd0d 100644 --- a/.github/workflows/wip-limit-check.yml +++ b/.github/workflows/wip-limit-check.yml @@ -2,7 +2,7 @@ name: WIP limit check on: pull_request: - types: [opened, ready_for_review] + types: [opened, reopened, ready_for_review] jobs: check: diff --git a/notebooks/traceblocTrainingGuide.ipynb b/notebooks/traceblocTrainingGuide.ipynb index d9a9ecc..b274519 100644 --- a/notebooks/traceblocTrainingGuide.ipynb +++ b/notebooks/traceblocTrainingGuide.ipynb @@ -103,8 +103,8 @@ "metadata": {}, "outputs": [], "source": [ - "# Clone the tracebloc model zoo (skip if you already have it)\n", - "!git clone https://github.com/tracebloc/model-zoo.git ../model-zoo 2>/dev/null || echo \"model-zoo already cloned\"" + "# Clone the tracebloc model zoo (skipped if it's already present)\n", + "![ -d ../model-zoo ] && echo \"model-zoo already present - skipping clone\" || git clone https://github.com/tracebloc/model-zoo.git ../model-zoo" ] }, {