(instance) function does not work with additional parameter

[priornix]

Hi,

Nice project.

Creating a ChromeDriver using the function from (webica.chrome-driver/start-chrome), but I am trying to create a ChromeDriver that takes in an additional ChromeOptions parameter, so I copied out (start-chrome) and modified it as follows:

(defn start-chrome [&[chromedriver args]]
  (let [driver-prop "webdriver.chrome.driver"
        default-exe (System/getProperty driver-prop)
        chromedriver-system "/usr/lib/chromium/chromedriver"
        chromedriver-local "/usr/local/bin/chromedriver"
        chromedriver (or chromedriver
                         (if (and (not (empty? default-exe))
                                  (fs/exists? default-exe))
                           default-exe)
                         (if (fs/exists? chromedriver-system)
                           chromedriver-system)
                       chromedriver-local)]
    (if-not (fs/exists? chromedriver)
      (throw
        (RuntimeException.
          (str "ERROR: chromedriver executable not found:" chromedriver))))
    (System/setProperty driver-prop chromedriver)
    (instance args)))

However, the (instance) introspection does not seem to be working and the ChromeDriver did not receive the correct options, as I have checked the ChromeDriver log files. It only worked when I replaced (instance args) with (ChromeDriver. args)

[tmarble]

Try (apply instance args) and see if that helps

[agilecreativity]

@priornix
I have included this implementation in the last PR please take a look.
This should have been implemented.

@tmarble
We should be able to safely closed this issue as it has been resolved.

[tmarble]

@agilecreativity there's a tiny signature change I want to make after your PR which is currently in progress.. then we can close this one.