[Bug]: installed version is incorrectly converted in detection script

[attiland]

I have discovered that there is an issue with the version detection script. Based on log in C:\ProgramData\Microsoft\IntuneManagementExtension\Logs in this example Keepass detection log says "DominikReichl.KeePass is installed but 2.59 is lower than expected 2.59.0, exit code 4" this means the length of the version number is handled incorrectly.

I use the below code for other scripts to compare software versions elsewhere. Surely could be neater, but well commented and could be used for base of something in your project.
@svrooij @crcobb @miyoyo @iFestral

function Software_VersionCompare{param($Version1, $Version2)
    #Return 0 if equal, 1 if Version1 is newer, 2 if Version2 newer
    #e.g.: Software_VersionCompare 5.1.2 "5.11" - will return 2 (doesn't matter if vesion is text or number, or how many subversion you have)
    #converting to text so Length can be acessed
    $Version1 = $Version1.tostring()
    $Version2 = $Version2.tostring()
    $CompareArray1 = $Version1.Split(".")
    $CompareArray2 = $Version2.Split(".")
    #extend missing Sub Versions
    if($CompareArray1.Count -eq $CompareArray2.Count){
        #same amount of SubVersions
        } else {
            $Diff = $CompareArray1.Count - $CompareArray2.Count
            If($Diff -lt 0){
                for($x=0;$x -lt $Diff*-1;$x++){
                    #addinng 0 to array 1 for empty
                    $CompareArray1 += "0"
                    }
                } else {
                for($x=0;$x -lt $Diff;$x++){
                    #addinng 0 to array 2 for empty
                    $CompareArray2 += "0"
                    }
                }
        }
    #Compering Length adding 0 to the end if required and convering to integer
    for($i=0;$i -lt $CompareArray1.Count-1;$i++){
        if($CompareArray1[$i].Length -eq $CompareArray2[$i].Length) {
            $CompareArray1[$i] = [int]$CompareArray1[$i]
            $CompareArray2[$i] = [int]$CompareArray2[$i]
            } else {
                $Diff = $CompareArray1[$i].Length - $CompareArray2[$i].Length
                If($Diff -lt 0){
                    for($x=0;$x -lt $Diff*-1;$x++){
                        #addinng 0 to array 1 for empty
                        $CompareArray1[$i] = $CompareArray1[$i]+"0"
                        }
                    } else {
                    for($x=0;$x -lt $Diff;$x++){
                        #addinng 0 to array 2 for empty
                        $CompareArray2[$i] = $CompareArray2[$i]+"0"
                        }
                    }
                $CompareArray1[$i] = [int]$CompareArray1[$i]
                $CompareArray2[$i] = [int]$CompareArray2[$i]
            }
        }
    # comparing each subversions as integer
    for($i=0;$i -lt $CompareArray1.Count;$i++){
        if([int]$CompareArray1[$i] -ne [int]$CompareArray2[$i]) {
                if(([int]$CompareArray1[$i] - [int]$CompareArray2[$i]) -gt 0) {
                    #write-host "Version1 is newer"
                    return 1
                    } else {
                    #write-host "Version2 is newer"
                    return 2
                    }
            } #else {#they are the same} 
        }
    Write-Host "they are the same"
    return 0
}

[svrooij]

@attiland please follow the regular flow for issues. No need to tag a lot of people in your first message. Need to know the version number and stuff like that.

[svrooij]

And for your information, if I package and deploy KeePass with the latest version, it packages an MSI installer. And creates a detection according to:

{
  "@odata.type": "#microsoft.graph.win32LobAppProductCodeDetection",
  "productCode": "{FBB2D312-7A6C-4CF9-A9B1-F7DADB0200CE}",
  "productVersion": "2.59.0",
  "productVersionOperator": "greaterThanOrEqual"
}

It does not use a detection script in this case. If you're saying that the reported version does not match the describe version. That is something to talk the author about.